[release-4.6] Bug 2002151: Fix the event listener optional types

[karthikjeeyar]

Fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=2002151

Analysis / Root cause:

OSP 1.2.3 in OCP-4.6.36, has older version of triggers which makes triggers.template.name as optional in eventlistener and accepts triggers.triggerRef (not supported in 4.6).

Solution Description:

Added a optional check to prevent the crashing in Pipelines list page in the UI.

Screen shots / Gifs for design review:

Test setup:

1. Create any pipeline and an eventlistener with triggerRef - eventListener.yaml.
2. Visit the pipeline list page or pipeline details page.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci]

@karthikjeeyar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix the event listener optional types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@karthikjeeyar: This pull request references Bugzilla bug 2002151, which is invalid:

• expected dependent Bugzilla bug 1941995 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2002151: Fix the event listener optional types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/bugzilla refresh

[openshift-ci]

@karthikjeeyar: This pull request references Bugzilla bug 2002151, which is invalid:

• expected dependent Bugzilla bug 1941995 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/bugzilla refresh

[openshift-ci]

@karthikjeeyar: This pull request references Bugzilla bug 2002151, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1944349 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1944349 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@karthikjeeyar: This pull request references Bugzilla bug 2002151, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1944349 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1944349 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

In response to this:

[release-4.6] Bug 2002151: Fix the event listener optional types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/lgtm

verified and works as expected

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hardys]

[patch-manager] Approving for cherry-pick with a score of 0.20 - appears to be a low risk fix for a medium priority user-visible issue

[openshift-ci]

@karthikjeeyar: All pull requests linked via external trackers have merged:

• openshift/console#10019

Bugzilla bug 2002151 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 2002151: Fix the event listener optional types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.