Temp fixes of scrolling-related issues on mobile #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Note: will need to be updated once #989 lands.
|
|
We should consider tracking things we want to rollback later somehow, maybe with issues. |
|
jenkins rebuild |
|
/hold for #989 |
rhamilto
added
the
do-not-merge/hold
|
jenkins rebuild |
rhamilto
removed
the
do-not-merge/hold
|
#989 needs rebase, so I'm gonna let this go in with the understanding @dtaylor113 will update it in his rebase. |
|
/hold It looks like #989 is already rebased. Just want to make sure we don't miss the name change. |
openshift-ci-robot
added
the
do-not-merge/hold
rhamilto
force-pushed
the
temp-nav-fixes
branch
from
13b6ac0
to
5079b22
Compare
rhamilto
removed
the
do-not-merge/hold
openshift-ci-robot
added
size/XS
|
Rebased following the merge of #989 |
|
jenkins rebuild |
1 similar comment
|
jenkins rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp fixes for:
Upstream issues:
vhunits in.pf-c-pageheightcauses wonky scrolling issues in iOS patternfly/patternfly#1174.pf-l-page__sidebarneeds-webkit-overflow-scrolling: touchto enable momentum-based scrolling patternfly/patternfly#1175