Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2002905: Fix list page route for build configs #10043

Merged
merged 1 commit into from Oct 29, 2021
Merged

[release-4.9] Bug 2002905: Fix list page route for build configs #10043

merged 1 commit into from Oct 29, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #10039

/assign spadgett

@TheRealJon
Bug 2001810: Fix list page route for build configs
7bbb216 
Update dev console plugin route for build configs to specify `perspective: 'dev'` so that it doesn't override the existing admin perspective route.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 10, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021

@openshift-cherrypick-robot: Bugzilla bug 2001810 has been cloned as Bugzilla bug 2002905. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2002905: Fix list page route for build configs

In response to this:

[release-4.9] Bug 2001810: Fix list page route for build configs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2001810: Fix list page route for build configs [release-4.9] Bug 2002905: Fix list page route for build configs Sep 10, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2002905, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2001810 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2001810 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

[release-4.9] Bug 2002905: Fix list page route for build configs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 10, 2021
@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Sep 10, 2021
spadgett
spadgett approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

/retest

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2021
@XiyunZhao
Copy link

This PR has been verified on OCP4.9, now, when user requests to view BuildConfigs in all namespaces, BuildConfigs list will be shown correctly without any improper message

@XiyunZhao
Copy link

/lgtm

@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 19, 2021
@kdoberst
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 28, 2021
yapei
yapei approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@yapei yapei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett, XiyunZhao, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a073e7f into openshift:release-4.9 Oct 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2002905 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2002905: Fix list page route for build configs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@yapei yapei yapei approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@sahil143 sahil143 Awaiting requested review from sahil143

Assignees

@spadgett spadgett

@XiyunZhao XiyunZhao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @spadgett @XiyunZhao @kdoberst @yapei @openshift-merge-robot @TheRealJon