Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2002696: Fix links and texts for Storage link provided in Overview page. #10050

Merged

Conversation

bipuladh
Copy link
Contributor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2021

@bipuladh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

1999076: Fix links and texts for Storage link provided in Overview page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2021

@bipuladh: GitHub didn't allow me to assign the following users: TimothyAsirJeyasing.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @SanjalKatiyar @TimothyAsirJeyasing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh bipuladh changed the title 1999076: Fix links and texts for Storage link provided in Overview page. Bug 1999076: Fix links and texts for Storage link provided in Overview page. Sep 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2021

@bipuladh: This pull request references Bugzilla bug 1999076, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1999076 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1999076: Fix links and texts for Storage link provided in Overview page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 12, 2021
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2021
@bipuladh bipuladh changed the title Bug 1999076: Fix links and texts for Storage link provided in Overview page. Bug 2002696: Fix links and texts for Storage link provided in Overview page. Sep 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2021

@bipuladh: This pull request references Bugzilla bug 2002696, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1999076 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1999076 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 2002696: Fix links and texts for Storage link provided in Overview page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 12, 2021
Comment on lines 35 to 38
"ceph-storage-plugin~Storage status represents the health status of Openshift Data Foundation's StorageCluster.",
)
: t(
"ceph-storage-plugin~Storage status represents the health status of Openshift Container Storage's StorageCluster.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ceph-storage-plugin~Storage status represents the health status of Openshift Data Foundation's StorageCluster.",
)
: t(
"ceph-storage-plugin~Storage status represents the health status of Openshift Container Storage's StorageCluster.",
"ceph-storage-plugin~Storage status represents the health status of OpenShift Data Foundation's StorageCluster.",
)
: t(
"ceph-storage-plugin~Storage status represents the health status of OpenShift Container Storage's StorageCluster.",

<Link to="/ocs-dashboards">{t('ceph-storage-plugin~Openshift Data Foundation')}</Link>
<Link to={isODF ? '/odf' : '/ocs-dashboards'}>
{isODF
? t('ceph-storage-plugin~Openshift Data Foundation')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
? t('ceph-storage-plugin~Openshift Data Foundation')
? t('ceph-storage-plugin~OpenShift Data Foundation')

"ceph-storage-plugin~Storage status represents the health status of OpenShift Data Foundation's StorageCluster.",
)
: t(
"ceph-storage-plugin~Storage status represents the health status of Openshift Container Storage's StorageCluster.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well, right ??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Openshift --> OpenShift

@SanjalKatiyar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bipuladh bipuladh changed the title Bug 2002696: Fix links and texts for Storage link provided in Overview page. [release-4.9] Bug 2002696: Fix links and texts for Storage link provided in Overview page. Sep 13, 2021
@bipuladh
Copy link
Contributor Author

/label staff-eng-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

@bipuladh: The label(s) /label staff-eng-approved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed

In response to this:

/label staff-eng-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/staff-eng-approved

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 17af94e into openshift:release-4.9 Oct 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

@bipuladh: All pull requests linked via external trackers have merged:

Bugzilla bug 2002696 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2002696: Fix links and texts for Storage link provided in Overview page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants