New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] Bug 2002696: Fix links and texts for Storage link provided in Overview page. #10050
[release-4.9] Bug 2002696: Fix links and texts for Storage link provided in Overview page. #10050
Conversation
@bipuladh: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bipuladh: GitHub didn't allow me to assign the following users: TimothyAsirJeyasing. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bipuladh: This pull request references Bugzilla bug 1999076, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bipuladh: This pull request references Bugzilla bug 2002696, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
"ceph-storage-plugin~Storage status represents the health status of Openshift Data Foundation's StorageCluster.", | ||
) | ||
: t( | ||
"ceph-storage-plugin~Storage status represents the health status of Openshift Container Storage's StorageCluster.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ceph-storage-plugin~Storage status represents the health status of Openshift Data Foundation's StorageCluster.", | |
) | |
: t( | |
"ceph-storage-plugin~Storage status represents the health status of Openshift Container Storage's StorageCluster.", | |
"ceph-storage-plugin~Storage status represents the health status of OpenShift Data Foundation's StorageCluster.", | |
) | |
: t( | |
"ceph-storage-plugin~Storage status represents the health status of OpenShift Container Storage's StorageCluster.", |
<Link to="/ocs-dashboards">{t('ceph-storage-plugin~Openshift Data Foundation')}</Link> | ||
<Link to={isODF ? '/odf' : '/ocs-dashboards'}> | ||
{isODF | ||
? t('ceph-storage-plugin~Openshift Data Foundation') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? t('ceph-storage-plugin~Openshift Data Foundation') | |
? t('ceph-storage-plugin~OpenShift Data Foundation') |
358b0ce
to
ad2e030
Compare
"ceph-storage-plugin~Storage status represents the health status of OpenShift Data Foundation's StorageCluster.", | ||
) | ||
: t( | ||
"ceph-storage-plugin~Storage status represents the health status of Openshift Container Storage's StorageCluster.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well, right ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Openshift
--> OpenShift
ad2e030
to
e2ce208
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label staff-eng-approved |
@bipuladh: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/staff-eng-approved |
@bipuladh: All pull requests linked via external trackers have merged: Bugzilla bug 2002696 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @SanjalKatiyar @TimothyAsirJeyasing