New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] Bug 2004241: Storage class name not passed in CR #10069
[release-4.9] Bug 2004241: Storage class name not passed in CR #10069
Conversation
…o error state - the name of storage class passed was empty because it was not getting set when a name of volume set is provided - we should set the name of storage class as the name of volume set when no explicit name is provided - fixes https://bugzilla.redhat.com/show_bug.cgi?id=2003651 Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@openshift-cherrypick-robot: Bugzilla bug 2003651 has been cloned as Bugzilla bug 2004241. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2004241, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/bugzilla refresh |
@afreen23: This pull request references Bugzilla bug 2004241, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@afreen23: This pull request references Bugzilla bug 2004241, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spadgett @christianvogt since we're past code freeze for 4.9, this can't merge without a staff-eng approval. As the console team doesn't have a staff eng representative at the moment, i'm prepared to proxy that approval from one of the two of you, as long as you understand the risk/reward tradeoffs associated w/ merging a change post-CF. We should only be doing it for things that absolutely can't wait for a 4.9.z. |
Just to give the background, this is a test blocker for QE. If 4.9.z is not so far , we can wait. |
not sure what our historical average is on weeks to the first .z release after the .0, but it should be O(weeks) after 4.9GA. that said, 4.9.0 doesn't GA until Oct 18th, so you're looking at early november if QE needs a build that they can test with, we have tools for producing builds for them, though that would include this PR on top of 4.9. (or they can use a 4.10 build?) |
Ack, that sounds fine then. It can be waited considering its not really a blocker for OCP but OCS.
Sure, would like to learn more of those. It might be helpful for at least conveying the possible solns. Thanks! |
we have a bot named cluster-bot on coreos.slack.com that allows you to build a release payload from a PR. you can then install a cluster from that payload:
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2004241 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #10064
/assign afreen23