New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] Bug 2004567: Fix basic spring boot sample form crash #10076
[release-4.9] Bug 2004567: Fix basic spring boot sample form crash #10076
Conversation
@openshift-cherrypick-robot: Bugzilla bug 2004060 has been cloned as Bugzilla bug 2004567. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2004567, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@divyanshiGupta: This pull request references Bugzilla bug 2004567, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jerolimov: This pull request references Bugzilla bug 2004567, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could verify that this change fixes the crash in 4.9 with Firefox.
But please notice that I created a follow up issue because this affects also other forms and I believe we should fix this in a more general way - hopefully without a try-catch-hack by improving the regex instead.
See https://bugzilla.redhat.com/show_bug.cgi?id=2014497 Regex slows down different forms and creates too much recursion errors in the log
As this crash doesn't happen in my tests on 4.8 I would accept that we backport this change to 4.9 (first).
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label backport-risk-assessed |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2004567 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #10013
/assign divyanshiGupta