Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2007136: Fix creation for BackingStore, BucketClass and NamespaceStore #10128

Merged
merged 1 commit into from Oct 27, 2021
Merged

Bug 2007136: Fix creation for BackingStore, BucketClass and NamespaceStore #10128

merged 1 commit into from Oct 27, 2021

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Sep 23, 2021 •
edited

Screenshots:
Successful creations via UI
Screenshot from 2021-09-23 14-06-44
Screenshot from 2021-09-23 14-06-39
Screenshot from 2021-09-23 14-06-32

@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@bipuladh: This pull request references Bugzilla bug 2007136, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 2007136: Fix creation for BackingStore, BucketClass and NamespaceStore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 23, 2021
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@bipuladh: This pull request references Bugzilla bug 2007136, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 2007136: Fix creation for BackingStore, BucketClass and NamespaceStore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rexagod
Copy link
Member

rexagod commented Oct 26, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a2d5954 into openshift:master Oct 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

@bipuladh: All pull requests linked via external trackers have merged:

Bugzilla bug 2007136 has been moved to the MODIFIED state.

In response to this:

Bug 2007136: Fix creation for BackingStore, BucketClass and NamespaceStore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/cherrypick release-4.9

@openshift-cherrypick-robot
Copy link

@bipuladh: #10128 failed to apply on top of branch "release-4.9":

Applying: Fix creation for BackingStore, BucketClass and NamespaceStore
Using index info to reconstruct a base tree...
M	frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.tsx
M	frontend/packages/ceph-storage-plugin/src/components/namespace-store/create-namespace-store.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/ceph-storage-plugin/src/components/namespace-store/create-namespace-store.tsx
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/components/namespace-store/create-namespace-store.tsx
Auto-merging frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.tsx
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix creation for BackingStore, BucketClass and NamespaceStore
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh bipuladh deleted the fix-creation branch October 27, 2021 10:52
@spadgett spadgett added this to the v4.10 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner Awaiting requested review from rawagner

@shyRozen shyRozen Awaiting requested review from shyRozen

@rexagod rexagod Awaiting requested review from rexagod

@afreen23 afreen23 Awaiting requested review from afreen23

Assignees

@rexagod rexagod

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bipuladh @rexagod @openshift-bot @openshift-cherrypick-robot @afreen23 @spadgett @openshift-merge-robot