Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2013088: node page fail #10210

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #10207

/assign jhadvig

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@openshift-cherrypick-robot: Bugzilla bug 2011809 has been cloned as Bugzilla bug 2013088. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2013088: node page fail

In response to this:

[release-4.9] Bug 2011809: node page fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2011809: node page fail [release-4.9] Bug 2013088: node page fail Oct 12, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2013088, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2011809 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2011809 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

[release-4.9] Bug 2013088: node page fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 12, 2021
@openshift-ci openshift-ci bot added the component/metal3 Related to metal3-plugin label Oct 12, 2021
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2021
@yapei
Copy link
Contributor

yapei commented Oct 12, 2021

verified that Compute -> Nodes page is shown correctly with the fix
Screen Shot 2021-10-12 at 7 43 35 PM

@yapei
Copy link
Contributor

yapei commented Oct 12, 2021

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 12, 2021
Copy link
Contributor

@yapei yapei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yapei
Copy link
Contributor

yapei commented Oct 13, 2021

@jhadvig @spadgett Shall we merge it and include the fix before 4.9 GA?

@jhadvig
Copy link
Member

jhadvig commented Oct 13, 2021

@yapei we should

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 13, 2021
@spadgett
Copy link
Member

@jhadvig @yapei I would say this shouldn't block 4.9 GA at this stage. This doesn't cause any data loss or break upgrades and only happens in certain specific circumstances. We can aim to fix in an early z-stream version.

@jhadvig
Copy link
Member

jhadvig commented Oct 13, 2021

/test frontend

@openshift-merge-robot openshift-merge-robot merged commit 0ab7825 into openshift:release-4.9 Oct 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2013088 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2013088: node page fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants