Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2015134: Reveal the switch status of the button "Show default project" in code #10252

Merged
merged 1 commit into from Oct 30, 2021
Merged

[release-4.9] Bug 2015134: Reveal the switch status of the button "Show default project" in code #10252

merged 1 commit into from Oct 30, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #10157

/assign kdoberst

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: Bugzilla bug 2005554 has been cloned as Bugzilla bug 2015134. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2015134: Reveal the switch status of the button "Show default project" in code

In response to this:

[release-4.9] Bug 2005554: Reveal the switch status of the button "Show default project" in code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2005554: Reveal the switch status of the button "Show default project" in code [release-4.9] Bug 2015134: Reveal the switch status of the button "Show default project" in code Oct 18, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2015134, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2005554 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2005554 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

[release-4.9] Bug 2015134: Reveal the switch status of the button "Show default project" in code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 18, 2021
@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Oct 18, 2021
@kdoberst
Copy link
Contributor

This impacts testing. The change is a minor change that does not impact how the application functions - so the risk of introducing new bugs is extremely low.

@kdoberst
Copy link
Contributor

/retest

@XiyunZhao
Copy link

This PR has been verified on OCP4.9, now, a new attributes 'data-checked-state' is added for the component whose data-set is 'showSystemSwitch'. When the user switches on/off the button, the new attribute 'data-checked-state' will show 'true' and 'false' to help user track the state of the button easily

@XiyunZhao
Copy link

/lgtm

@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 19, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@kdoberst
Copy link
Contributor

/retest

2 similar comments
@kdoberst
Copy link
Contributor

/retest

@kdoberst
Copy link
Contributor

/retest

@kdoberst
Copy link
Contributor

/approved

@kdoberst
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
jhadvig
jhadvig approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, kdoberst, openshift-cherrypick-robot, XiyunZhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stleerh stleerh added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7bf6b61 into openshift:release-4.9 Oct 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2015134 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2015134: Reveal the switch status of the button "Show default project" in code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@XiyunZhao XiyunZhao Awaiting requested review from XiyunZhao

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@XiyunZhao XiyunZhao

@kdoberst kdoberst

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @kdoberst @XiyunZhao @jhadvig @openshift-merge-robot @stleerh