Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2015500 - Storage - PersistentVolumeClaims : PersistentVolumes colum value 'No Persistent Volume' in English #10288

Closed
wants to merge 1 commit into from
Closed

Bug 2015500 - Storage - PersistentVolumeClaims : PersistentVolumes colum value 'No Persistent Volume' in English #10288

wants to merge 1 commit into from

Conversation

maudem
Copy link
Contributor

@maudem maudem commented Oct 21, 2021

On on Storage > PersistantVolumeClaims page, marked 'PersistentVolumes' value for localization.

Screenshot showing ?lng=en&pseudolocaliztation=true

Screen Shot 2021-10-21 at 11 58 34 AM

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 21, 2021
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 31, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maudem
To complete the pull request process, please assign bparees after the PR has been reviewed.
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maudem maudem force-pushed the bug-2015500 branch 2 times, most recently from 2e1afed to 61c630a Compare November 1, 2021 18:45
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2021
@maudem
Copy link
Contributor Author

maudem commented Nov 4, 2021

/retest-required

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2021
add translation
99ac71b 
revert "other changes"

fix typo and merge conflict
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021 •
edited

@maudem: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 99ac71b link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maudem maudem closed this Nov 11, 2021
@maudem
Copy link
Contributor Author

maudem commented Nov 11, 2021

Resolved by #10245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoto kyoto Awaiting requested review from kyoto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees
No one assigned
Labels
component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maudem