Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clean PF components for building Overview cards #10410

Merged
merged 1 commit into from Dec 13, 2021
Merged

Use clean PF components for building Overview cards #10410

merged 1 commit into from Dec 13, 2021

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Nov 8, 2021 •
edited

screencapture-localhost-9000-dashboards-2021-11-09-09_50_37

This PR also exposes Overview and OverviewGrid components via dynamic plugin API & removes Dashboard/DashboardGrid from internal one

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dashboard Related to dashboard labels Nov 8, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Nov 8, 2021
@rawagner rawagner force-pushed the card_pf branch 2 times, most recently from 1465f39 to 93ecff0 Compare November 9, 2021 08:04
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Nov 9, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2021
@rawagner
Copy link
Contributor Author

rawagner commented Nov 9, 2021

/retest

@rawagner
Copy link
Contributor Author

rawagner commented Nov 9, 2021

@andybraren @mceledonia can you take a look ?

@spadgett
Copy link
Member

spadgett commented Nov 9, 2021

@bipuladh FYI

@rawagner
Copy link
Contributor Author

rawagner commented Nov 9, 2021

/retest

@rawagner rawagner changed the title [WIP] Use clean PF components for building Overview cards Use clean PF components for building Overview cards Nov 10, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rawagner
Copy link
Contributor Author

/hold
e2e tests are failing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2021 •
edited

@rawagner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 9b73dec link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rawagner
Use clean PF components for building Overview cards
fb0aba8 
Expose Overview & OverviewGrid components
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@rawagner
Copy link
Contributor Author

/label docs-approved
/label px-approved

Nothing to document here, it just a visual update to align with PF

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Dec 13, 2021
@rawagner
Copy link
Contributor Author

/hold cancel

jtomasek
jtomasek approved these changes Dec 13, 2021
View reviewed changes
Copy link

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 35021e0 into openshift:master Dec 13, 2021
@SanjalKatiyar SanjalKatiyar mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybraren andybraren andybraren left review comments

@jtomasek jtomasek jtomasek approved these changes

@spadgett spadgett spadgett approved these changes

@afreen23 afreen23 Awaiting requested review from afreen23

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

Assignees

@jtomasek jtomasek

@spadgett spadgett

@yapei yapei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@rawagner @spadgett @bipuladh @yanpzhan @glekner @andybraren @openshift-bot @jtomasek @yapei @openshift-merge-robot