New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2020483: Monitoring dashboards: Improve display text for interval variables #10472
Bug 2020483: Monitoring dashboards: Improve display text for interval variables #10472
Conversation
@kyoto: This pull request references Bugzilla bug 2020483, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tested with PR, "API Performance" dashboard, Period field "$__auto_interval_period" is changed to "Auto interval ($__auto_interval_period)", auto interval period is 5m. |
/label qe-approved |
/bugzilla refresh The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity. |
@openshift-bot: This pull request references Bugzilla bug 2020483, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
/bugzilla refresh |
@kyoto: This pull request references Bugzilla bug 2020483, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
619e592
to
706be05
Compare
@kyoto: This pull request references Bugzilla bug 2020483, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changed this to use a popup tooltip on the "Auto interval" entry. |
Some variables are treated specially for setting an appropriate interval value. If a dropdown contains one of these variables, display readable text instead of just the variable name.
706be05
to
0fccfa3
Compare
/cc @jgbernalp |
@kyoto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, juzhao, kyoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kyoto: All pull requests linked via external trackers have merged: Bugzilla bug 2020483 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Some variables are treated specially for setting an appropriate interval
value. If a dropdown contains one of these variables, display readable
text instead of just the variable name.