Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gherkin for dev console usability improvements #10538

Conversation

sanketpathak
Copy link
Contributor

Epic: https://issues.redhat.com/browse/ODC-6303
Story: https://issues.redhat.com/browse/ODC-6421

Acceptance criteria:

  • The Add page should provide access to the same Quick Add/Search feature that we have available in topology
  • The "Logs" tab of a failed PipelineRun should include the "Log snippet"

Checks required for approving Epic gherkin scripts PR:

  • Add @epic-number to the scenarios or feature file [e.g: @odc-xxx]
  • Add @to-do for automation possible scenarios
  • Add @regression or @smoke based on the importance of the scenario
  • Update the test scenarios count in Automation status confluence Report
  • Check for the linter issues by executing yarn run gherkin-lint on frontend folder [Skip epic number tags related linter issues]

@sanketpathak sanketpathak changed the title gherkin for dev console usability improvements-ODC-6303 Gherkin for dev console usability improvements Nov 23, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/pipelines Related to pipelines-plugin labels Nov 23, 2021
@sanketpathak
Copy link
Contributor Author

/retest


@regression @to-do
Scenario: Quick Add of Quick Starts: AQS-01-TC05
Given user is at topology graph view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be User is at add page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code accordingly


@regression @to-do
Scenario: Quick Add of Devfile: AQS-01-TC06
Given user is at topology graph view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here . This should be User is at add page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code accordingly

And user enters "monitor" in Add to project search bar
And user selects Monitor your sample application option
And user clicks on Start
Then Monitor your sample application quick start displays in the Topology
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then Monitor your sample application quick start displays in the Topology
Then Monitor your sample application quick start displays in the Add page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code accordingly

@sanketpathak sanketpathak force-pushed the gherkin-devconsole-usability-improvements-odc-6303 branch from 3bbfb13 to 6b9c9cd Compare November 23, 2021 13:19
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanketpathak, vikram-raj
To complete the pull request process, please assign psrna after the PR has been reviewed.
You can assign the PR to them by writing /assign @psrna in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

@sanketpathak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 6b9c9cd link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Given pipeline is present on Pipeline Details page
When user selects "Start" option from kebab menu for pipeline "pipeline-two"
And user navigates to pipelineRun logs tab
Then user is able to see "Log snippet" for failure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add last line to this page



@smoke @to-do
Scenario: Add to project button in Add page: AQS-01-TC01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scenarios are related to add flow, so can we have "A-" instead of "AQS-"
Same for remaining scenarios

@makambalaji
Copy link
Contributor

@VeereshAradhya - Can you please take a look at the pipeline scenarios
cc: @jrichter1

@sanketpathak
Copy link
Contributor Author

Closing it in favor of #10554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dev-console Related to dev-console component/pipelines Related to pipelines-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants