Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2032421: UI integration with new auto update images #10659

Merged
merged 1 commit into from Dec 17, 2021
Merged

Bug 2032421: UI integration with new auto update images #10659

merged 1 commit into from Dec 17, 2021

Conversation

metalice
Copy link
Contributor

@metalice metalice commented Dec 14, 2021 •
edited

Signed-off-by: Matan Schatzman mschatzm@redhat.com

Fixes:
https://issues.redhat.com/browse/CNV-11922
Bug 2032421

Solution Description:
UI now supports DataSource objects, will show available boot source to all new common templates that will contain DataSource and existing matching PVC.

Tech Debt:
Advanced wizard is not getting the PVC to clone. should be fixed in next PR.

Screen shots / Gifs for design review:
datasource

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Dec 14, 2021
@metalice metalice changed the title UI integration with new auto update images Bug 2032421: UI integration with new auto update images Dec 14, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@metalice: This pull request references Bugzilla bug 2032421, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2032421: UI integration with new auto update images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@metalice: This pull request references Bugzilla bug 2032421, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2032421: UI integration with new auto update images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

avivtur
avivtur reviewed Dec 15, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/src/models/index.ts
apiVersion: 'v1bete1',
apiGroup: 'cdi.kubevirt.io',
plural: 'datasources',
abbr: 'datasources',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be ds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i asked what is the abbr for tat, the answer that I got is none.. so I don't really know. I'm guessing I change it to ds

Copy link
Contributor

@avivtur avivtur Dec 15, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing to DS would be best

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To find the apprv:
oc describe crd datasources on a cluster that has it:
and look for "Short names:"

For example:

oc describe crd datavolume
...
Plural:     datavolumes
    Short Names:
      dv
      dvs
    Singular:  datavolume

It looks to me like ds does not have abbrv in this api version.

Copy link
Contributor Author

@metalice metalice Dec 15, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacov so should I remove the abbr or leave it as it is? the abbr is required by K8SKind , so I will require me to change some other file if ill remove it.

frontend/packages/kubevirt-plugin/src/models/index.ts Outdated Show resolved Hide resolved
pcbailey
pcbailey reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nitpicks, but overall it looks good to me.

frontend/packages/kubevirt-plugin/src/components/create-vm/hooks/use-vm-templates-resources.tsx Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/statuses/template/template-source-status.ts Outdated Show resolved Hide resolved
@metalice
UI integration with new auto update images
749b3e9 
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@metalice: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-plugin 749b3e9 link true /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 53fd40a into openshift:master Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 2032421 has been moved to the MODIFIED state.

In response to this:

Bug 2032421: UI integration with new auto update images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@glekner glekner glekner left review comments

@avivtur avivtur avivtur left review comments

@gouyang gouyang Awaiting requested review from gouyang

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@metalice @pcbailey @openshift-bot @yaacov @glekner @avivtur @openshift-merge-robot