Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pipeline task hubURL link #10703

Merged
merged 1 commit into from Dec 27, 2021
Merged

add pipeline task hubURL link #10703

merged 1 commit into from Dec 27, 2021

Conversation

abhinandan13jan
Copy link
Contributor

@abhinandan13jan abhinandan13jan commented Dec 20, 2021 •
edited

Addresses

https://issues.redhat.com/browse/ODC-6434

Description

Adds a "Read More" link which points to hubURL for a particular Task Version.

Screenshots

Screenshot 2021-12-21 at 10 19 43 PM

Tests

Added Hub URL check

Browser conformance

Chrome

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Dec 20, 2021
debsmita1
debsmita1 suggested changes Dec 21, 2021
View reviewed changes
frontend/packages/pipelines-plugin/src/components/quicksearch/PipelineQuickSearchDetails.tsx Outdated
target="_blank"
>
read more
</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use ExternalLink component here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Dec 21, 2021
karthikjeeyar
karthikjeeyar reviewed Dec 21, 2021
View reviewed changes
frontend/packages/pipelines-plugin/src/components/quicksearch/PipelineQuickSearchDetails.tsx Outdated
Comment on lines 42 to 43
const hubURL = selectedItem.data?.latestVersion?.hubURL;
const hubLink = hubURL && `${TEKTON_HUB_ENDPOINT}/${hubURL}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will set the latestVersion.hubUrl for all the available task versions. for eg: the same link will be used for multiple versions (0.1 and 0.2 will have same Read more link).
Ideally, the hubUrl should be read from versions variable in line number 41 and when the version is changed, the hubLink should be formed based on the selected version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

frontend/packages/pipelines-plugin/src/components/quicksearch/PipelineQuickSearchDetails.tsx Outdated
additionalClassName="opp-quick-search-details__hublink"
dataTestID="task-hub-link"
href={hubLink}
text={t('pipelines-plugin~read more')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text={t('pipelines-plugin~read more')}
text={t('pipelines-plugin~Read more')}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@abhinandan13jan abhinandan13jan force-pushed the pipelinelink branch 2 times, most recently from dfe8dce to 62b5ae7 Compare December 21, 2021 16:52
@abhinandan13jan
Copy link
Contributor Author

cc: @beaumorley @siamaksade

karthikjeeyar
karthikjeeyar approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go with the Read more text as a link text for now, Let us revisit this with PM/UX on January and make necessary changes if it is needed.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 22, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 27, 2021
@abhinandan13jan
Copy link
Contributor Author

/test e2e-gcp-console

@debsmita1
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, debsmita1, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karthikjeeyar
Copy link
Contributor

Propagating the acks from the Epic

/label docs-approved
/label px-approved

Since the API is not available yet, we couldn't verify it on the cluster( I outlined this qe verification issue due to lack of API availability in the story as well). However I have verified using mock API and in localhost.

/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Dec 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 27, 2021

@abhinandan13jan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e846c6a into openshift:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debsmita1 debsmita1 debsmita1 requested changes

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees

@debsmita1 debsmita1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhinandan13jan @debsmita1 @karthikjeeyar @openshift-merge-robot