Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2044089: Update CRW operator name to fix failing e2e tests #10910

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Jan 23, 2022

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2044089

Analysis / Root cause:
All our 4.9 backports are currently stuck and could not be merged because an e2e test for the CRW integration doesn't pass anymore. The test checks if the exact displayName was part of the "Installed operators" page after installing it.

  1) Installing "Red Hat CodeReady Workspaces" operator in test-jmmhh
       Installs Red Hat CodeReady Workspaces operator in test-jmmhh and creates CodeReady Workspaces instance Specification operand instance:
     AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-test-id="operator-install-btn"]`, but never found it.
      at Context.eval (https://console-openshift-console.apps.ci-op-tnv4lhm2-a596c.**********************/__cypress/tests?p=tests/operator-install-single-namespace.spec.ts:13659:57)

All 4.9 jobs failing at the moment:

image

Solution Description:
Installed Operator page on 4.9 and 4.10 looks now like this (see also data-test-operator-row):

Screenshot from 2022-01-23 16-07-20

Update the expected CRW operator name from "Red Hat CodeReady Workspaces" to "Red Hat CodeReady Workspaces for Devfile v1 and v2".

Screen shots / Gifs for design review:
Unchanged

Unit test coverage report:
Unchanged

Test setup:
If this PR passes again we are fine. 馃槒

Browser conformance:
Unrelated

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@jerolimov: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Update CRW operator name to fix failing e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@jerolimov: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Update CRW operator name to fix failing e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@jerolimov: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Update CRW operator name to fix failing e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@jerolimov: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Update CRW operator name to fix failing e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov jerolimov changed the title [release-4.9] Update CRW operator name to fix failing e2e tests Bug 2044089: [release-4.9] Update CRW operator name to fix failing e2e tests Jan 23, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@jerolimov: This pull request references Bugzilla bug 2044089, which is invalid:

  • expected Bugzilla bug 2044089 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2044089: [release-4.9] Update CRW operator name to fix failing e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov jerolimov changed the title Bug 2044089: [release-4.9] Update CRW operator name to fix failing e2e tests [release-4.9] Bug 2044089: Update CRW operator name to fix failing e2e tests Jan 23, 2022
@jerolimov
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@jerolimov: This pull request references Bugzilla bug 2044089, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2044090 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2044090 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 23, 2022
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@sanketpathak
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 408d24e into openshift:release-4.9 Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@jerolimov: All pull requests linked via external trackers have merged:

Bugzilla bug 2044089 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2044089: Update CRW operator name to fix failing e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/cherry-pick release-4.8

@openshift-cherrypick-robot

@jerolimov: #10910 failed to apply on top of branch "release-4.8":

Applying: Update CRW operator name to fix failing e2e tests
Using index info to reconstruct a base tree...
A	frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-uninstall.spec.ts
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-uninstall.spec.ts deleted in HEAD and modified in Update CRW operator name to fix failing e2e tests. Version Update CRW operator name to fix failing e2e tests of frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-uninstall.spec.ts left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update CRW operator name to fix failing e2e tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants