[release-4.9] Bug 2046016: SnapShot with Disk Hot-plug hangs

[avivtur]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2046016

Analysis / Root cause:
missing check for hotplug volumes

Solution Description:
adding check for hotplug volumes and toggling the alerts as needed

Screen shots / Gifs for design review:

Before:

After:

Signed-off-by: Aviv Turgeman aturgema@redhat.com

[openshift-ci]

@avivtur: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 2047371 - live snapshot is allowed with hotplugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

@avivtur do you know about this ?
kubevirt/kubevirt#7127

[avivtur]

@yaacov yes I was aware of that PR,
this is a bug suggested to me by @ShellyKa13,
@ShellyKa13 can you please review the fix?

[ShellyKa13]

looks ok to me.
just making sure that this change is only for 4.9, in 4.10 hotplug will be supported. the bug fix that was mentioned here will be in 4.10.
Also making sure that in 4.10 hotplug disks will be in the snapshot only if they are persistent, i.e should be mentioned that for non-persistent hotplug disks that they will not be in the snapshot.

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 2046016, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2045199 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2045199 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2046016: SnapShot with Disk Hot-plug hangs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[avivtur]

looks ok to me. just making sure that this change is only for 4.9, in 4.10 hotplug will be supported. the bug fix that was mentioned here will be in 4.10.

@ShellyKa13 Hi, first of all thank you for looking :)
this PR is for 4.9 only and should not affect 4.10 at all, as hotplugs should be allowed in live snapshots.

Also making sure that in 4.10 hotplug disks will be in the snapshot only if they are persistent, i.e should be mentioned that for non-persistent hotplug disks that they will not be in the snapshot.

for non persistent hotplugs there is an indication when listing all volumes which are not included in snapshot, it looks like this:
disk-1 - Volume snapshots are not supported for auto-detach hotplug volumes.

[avivtur]

/retest

[yaacov]

/retitle [release-4.9] Bug 2046016: SnapShot with Disk Hot-plug hangs

[yaacov]

/label backport-risk-assessed

[avivtur]

/retest

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 2046016, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2045199 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2045199 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @gouyang

In response to this:

[release-4.9] Bug 2046016: SnapShot with Disk Hot-plug hangs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 2046016, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2045199 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2045199 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @gouyang

In response to this:

[release-4.9] Bug 2046016: SnapShot with Disk Hot-plug hangs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[avivtur]

/retest

[gouyang]

/label cherry-pick-approved

[yaacov]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gouyang]

/retest

[openshift-ci]

@avivtur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@avivtur: All pull requests linked via external trackers have merged:

• openshift/console#10959

Bugzilla bug 2046016 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2046016: SnapShot with Disk Hot-plug hangs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.