[release-4.9] Bug 2047350: Fix TypeError when application has HelmRelease

[jerolimov]

This PR includes the automated cherry-pick of #10742 by @vikram-raj as well as a 2nd commit which fixes another error (NPE) when selecting an application with just a Helm Release in it.

Fixed error:

Uncaught TypeError: Cannot read properties of undefined (reading 'metadata')
    at groupActions.ts:74:1
    at arrayReduce (_arrayReduce.js:21:1)
    at Module.reduce (reduce.js:48:1)
    at addResourcesMenu (groupActions.ts:69:1)
    at groupActions (groupActions.ts:98:1)
    at TopologyApplicationPanel (TopologyApplicationPanel.tsx:24:1)
    ...

The above error occurred in the <TopologyApplicationPanel> component:
    at TopologyApplicationPanel
    at div
    at div
    at TopologySideBar
    at TopologySideBar
    ...

TypeError: Cannot read properties of undefined (reading 'metadata')
    at groupActions.ts:74:1
    at arrayReduce (_arrayReduce.js:21:1)
    at Module.reduce (reduce.js:48:1)
    at addResourcesMenu (groupActions.ts:69:1)
    at groupActions (groupActions.ts:98:1)
    at TopologyApplicationPanel (TopologyApplicationPanel.tsx:24:1)
    ...

@vikram-raj Can you please take a look if this is fine for you? I think this PR can replace #10958 because its included here.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2047350, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2029579 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2029579 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.9] Bug 2047350: Fix TypeError when application has HelmRelease

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/label backport-risk-assessed

[jerolimov]

/cc @vikram-raj

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2047350, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2029579 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2029579 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.9] Bug 2047350: Fix TypeError when application has HelmRelease

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/retest

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2047350, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2029579 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2029579 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.9] Bug 2047350: Fix TypeError when application has HelmRelease

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikram-raj]

Thanks @jerolimov for this PR.

I noticed an issue. i:e the actions menu and context menu is present for the application group which has helm node present into it.

[jerolimov]

I noticed an issue. i:e the actions menu and context menu is present for the application group which has helm node present into it.

Hey @vikram-raj, thanks for testing this. I updated the PR so that the primary resource now ignores helm charts, but if the second or third resource contains a resource it shows the menu. In other words: If the application group contains ONLY helm charts it still does not show a menu, in your case it shows the menu again.

Peek.2022-02-09.09-32.mp4

So this PR is all about fixing the crash. At the moment we "official do not support" Helm Release grouping in topology. We will add group support as part of RFE-2212.

[jrichter1]

/label cherry-pick-approved

[vikram-raj]

Thanks @jerolimov, verified it. and it works as expected.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/topology/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vikram-raj]

/retest

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#10990

Bugzilla bug 2047350 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2047350: Fix TypeError when application has HelmRelease

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@jerolimov: new pull request created: #11069

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.