Bug 2037628: added test-id to kms flows #11003

RishabhKodes · 2022-02-07T06:19:58Z

Added the test id in the kms flow for automation

openshift-ci · 2022-02-07T06:20:02Z

@RishabhKodes: This pull request references Bugzilla bug 2037628, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2037628: added test-id to kms flows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RishabhKodes · 2022-02-07T06:20:26Z

@RishabhKodes: This pull request references Bugzilla bug 2037628, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

/bugzilla refresh

openshift-ci · 2022-02-07T06:20:28Z

@RishabhKodes: This pull request references Bugzilla bug 2037628, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

@RishabhKodes: This pull request references Bugzilla bug 2037628, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-02-07T06:20:33Z

Hi @RishabhKodes. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23

Add test ids to all FileUploads

/ok-to-test

afreen23 · 2022-02-07T08:11:47Z

...ckages/ceph-storage-plugin/src/components/modals/advanced-kms-modal/advanced-vault-modal.tsx

@@ -253,6 +254,7 @@ export const AdvancedVaultModal = withHandlePromise((props: AdvancedKMSModalProp
                maxSize: KMSMaxFileUploadSize,
                onDropRejected: () => setError(KMSFileSizeErrorMsg),
              }}
+              data-test="kms-service-cert"


Suggested change

data-test="kms-service-cert"

data-test="kms-service-client-cert"

afreen23 · 2022-02-07T08:12:21Z

...ckages/ceph-storage-plugin/src/components/modals/advanced-kms-modal/advanced-vault-modal.tsx

@@ -273,6 +275,7 @@ export const AdvancedVaultModal = withHandlePromise((props: AdvancedKMSModalProp
                maxSize: KMSMaxFileUploadSize,
                onDropRejected: () => setError(KMSFileSizeErrorMsg),
              }}
+              data-test="kms-service-key"


Suggested change

data-test="kms-service-key"

data-test="kms-service-client-private-key"

afreen23 · 2022-02-07T08:12:35Z

/bugzilla refresh

openshift-ci · 2022-02-07T08:12:42Z

@afreen23: This pull request references Bugzilla bug 2037628, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (amagrawa@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23

/lgtm

openshift-ci · 2022-02-07T08:22:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, RishabhKodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-02-07T10:34:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-02-07T12:37:43Z

@RishabhKodes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-02-07T12:38:26Z

@RishabhKodes: All pull requests linked via external trackers have merged:

openshift/console#11003

Bugzilla bug 2037628 has been moved to the MODIFIED state.

In response to this:

Bug 2037628: added test-id to kms flows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 7, 2022

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 7, 2022

openshift-ci bot requested review from bipuladh and cloudbehl February 7, 2022 06:20

openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Feb 7, 2022

afreen23 suggested changes Feb 7, 2022

View reviewed changes

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2022

added test-id's to kms flows

7ffaea1

RishabhKodes force-pushed the testId-fix branch from f84f135 to 7ffaea1 Compare February 7, 2022 08:04

afreen23 suggested changes Feb 7, 2022

View reviewed changes

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 7, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 7, 2022

updated test id's

930a2d2

afreen23 approved these changes Feb 7, 2022

View reviewed changes

openshift-ci bot assigned afreen23 Feb 7, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022

openshift-merge-robot merged commit 508a3c9 into openshift:master Feb 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2037628: added test-id to kms flows #11003

Bug 2037628: added test-id to kms flows #11003

RishabhKodes commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

RishabhKodes commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

afreen23 left a comment

afreen23 Feb 7, 2022

afreen23 Feb 7, 2022

afreen23 commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

afreen23 left a comment

openshift-ci bot commented Feb 7, 2022

openshift-bot commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

	data-test="kms-service-cert"
	data-test="kms-service-client-cert"

	data-test="kms-service-key"
	data-test="kms-service-client-private-key"

Bug 2037628: added test-id to kms flows #11003

Bug 2037628: added test-id to kms flows #11003

Conversation

RishabhKodes commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

RishabhKodes commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

afreen23 left a comment

Choose a reason for hiding this comment

afreen23 Feb 7, 2022

Choose a reason for hiding this comment

afreen23 Feb 7, 2022

Choose a reason for hiding this comment

afreen23 commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

afreen23 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Feb 7, 2022

openshift-bot commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022

openshift-ci bot commented Feb 7, 2022