New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2046618: Add started-by annotation to pipelines created with "Start last run" #11005
Bug 2046618: Add started-by annotation to pipelines created with "Start last run" #11005
Conversation
@rottencandy: This pull request references Bugzilla bug 2046618, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rottencandy: This pull request references Bugzilla bug 2046618, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @karthikjeeyar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Saud for fixing the annotations.
I noticed that pipelineRun's are not annotated (started-by) when the user goes through the Add flows with pipeline option checked. Its good to be consistent in having these annotations even in git import flow as well.
599efd7
to
3672bbd
Compare
Added annotation to PipelineRuns created using import flow. |
tried out the changes and it works fine |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, karthikjeeyar, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@rottencandy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@rottencandy: All pull requests linked via external trackers have merged: Bugzilla bug 2046618 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.10 |
@rottencandy: new pull request created: #11015 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/OCPBUGSM-39963
Analysis / Root cause:
PipelineRuns created using the start last run button in pipeline details page & list view did not update the started-by annotation.
Solution Description:
Add/update the started-by annotation when creating pipelineRuns using the "start last run" button.
Screen shots / Gifs for design review:
0.mp4
Unit test coverage report:
(Unchanged)
Test setup:
Browser conformance: