Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 2052858: Add subject name selector field to SinkBinding form #11026

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #10925

/assign rottencandy

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@openshift-cherrypick-robot: Bugzilla bug 2045051 has been cloned as Bugzilla bug 2052858. Retitling PR to link against new bug.
/retitle [release-4.7] [release-4.8] Bug 2052858: Add subject name selector field to SinkBinding form

In response to this:

[release-4.7] [release-4.8] Bug 2045051: Add subject name selector field to SinkBinding form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2045051: Add subject name selector field to SinkBinding form [release-4.7] [release-4.8] Bug 2052858: Add subject name selector field to SinkBinding form Feb 10, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2052858, which is invalid:

  • expected dependent Bugzilla bug 2045051 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] [release-4.8] Bug 2052858: Add subject name selector field to SinkBinding form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/knative Related to knative-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Feb 10, 2022
@rottencandy
Copy link
Contributor

/assign @jerolimov

@jerolimov
Copy link
Member

/retitle [release-4.7] Bug 2052858: Add subject name selector field to SinkBinding form

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2052858: Add subject name selector field to SinkBinding form [release-4.7] Bug 2052858: Add subject name selector field to SinkBinding form Feb 10, 2022
@jerolimov
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change as in 4.8 and all versions above. And it works here similar to the backport to 4.8 and 4.9.

Tested on a cluster bot:

pr-11026.mp4

Generated sink:

Screenshot from 2022-02-15 13-27-10

/lgtm
/approve
Same code as in 4.11. Tested on a cluster bot instance:

pr-11036.mp4
/lgtm
/approve
/label backport-risk-assessed
/cc @jrichter1

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 15, 2022
@jerolimov
Copy link
Member

/bugzilla refresh
/cc @sanketpathak

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@jerolimov: This pull request references Bugzilla bug 2052858, which is invalid:

  • expected dependent Bugzilla bug 2045051 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
/cc @sanketpathak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@jerolimov
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@jerolimov: This pull request references Bugzilla bug 2052858, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2045051 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2045051 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/assign @invincibleJai

@jrichter1
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 15, 2022
@invincibleJai
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 59f13ba into openshift:release-4.7 Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2052858 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2052858: Add subject name selector field to SinkBinding form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/knative Related to knative-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants