Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 2052859: override normal namespace hiding for pods view in node details #11027

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #8253

/assign jhadvig

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@openshift-cherrypick-robot: Bugzilla bug 1929243 has been cloned as Bugzilla bug 2052859. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 2052859: override normal namespace hiding for pods view in node details

In response to this:

[release-4.7] Bug 1929243: override normal namespace hiding for pods view in node details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1929243: override normal namespace hiding for pods view in node details [release-4.7] Bug 2052859: override normal namespace hiding for pods view in node details Feb 10, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2052859, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1929243 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1929243 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @schituku

In response to this:

[release-4.7] Bug 2052859: override normal namespace hiding for pods view in node details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2022
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Feb 10, 2022
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2022
@jhadvig
Copy link
Member

jhadvig commented Feb 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@XiyunZhao
Copy link

Hi @jhadvig, please help to double confirm the scenario as below shown, some update may need
Peek 2022-02-11 16-10
Description:
This issue will only happen after user selected 'Namespace' column on Pod page, then select 'Namespace' column function will not be working on Node Details Pod tab page.
Reproduce Step:
1.Login OCP, navigate to Pod page, select 'openshift-console' as a project, check the column, and make sure 'Namespace' is being selected on 'Manage columns' windows
2.Navigate to Node -> Node Details Page -> Pod Tab, select/unselect the column of 'Namespace', check if the function is working
Actual results:
2. The 'Namespace' column will be displayed on page forever
Expected Result:
2. The 'Namespace' column should display by follow the option that user selected

@jhadvig
Copy link
Member

jhadvig commented Feb 11, 2022

@jcaianirh could you please assist here on what the issue cause could be?

@XiyunZhao
Copy link

This bug has re-verified on private build (launch OCP with PR), upon issue is gone.
No issue found on this changes now

@XiyunZhao
Copy link

/lgtm

@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot, XiyunZhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanpzhan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 59d7e2b into openshift:release-4.7 Mar 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2052859 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2052859: override normal namespace hiding for pods view in node details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants