Bug 2014161: Fix pipeline run logs autoscrolling issue #11056
Conversation
openshift-ci
bot
added
component/pipelines
| blockContentRef.current = ''; | ||
| }, 300); | ||
|
|
||
| const contentScrollerRef = React.useRef<() => void>(addContentAndScroll); |
There was a problem hiding this comment.
Why do we need a ref for a throttled function?
There was a problem hiding this comment.
Ref is not needed and I have updated the code to use useCallback.
karthikjeeyar
force-pushed
the
fix-pipeline-logs
branch
from
bcbf576
to
007fde2
Compare
|
@karthikjeeyar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
karthikjeeyar
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@karthikjeeyar: This pull request references Bugzilla bug 2014161, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karthikjeeyar, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@karthikjeeyar: All pull requests linked via external trackers have merged: Bugzilla bug 2014161 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.10 |
|
@karthikjeeyar: new pull request created: #11092 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/OCPBUGSM-36824
Analysis / Root cause:
High volume of data streaming into the logs components, causes too many calls to scrollIntoView method. It results failure to autoscroll to the latest content and sometimes the browser goes unresponsive.
Solution Description:
Added throttling to the append the content to the dom and to scroller function.
Screen shots / Gifs for design review:
piepline-logs-autoscroll.mov
Unit test coverage report:
No tests changed.
Test setup:
Browser conformance: