[release-4.7] Bug 2060451: Fix a crash when the preferred namespace contains just numbers #11135

jerolimov · 2022-03-03T14:51:48Z

Manually backport of #11129

This issue has different behavior on the different versions and it is primarily here to fix a crash in 4.7:

4.6: Just works fine
4.7: Crash
4.8: Does not crash, but the namespace was not automatically selected when switching to it.
4.9-4.11: Works fine, but update the hook to fix potential other issues when a namespace is a number.

So this might be the most interesting PR:

master: Bug 2009345: Fix potential issues with namespaces that contains just numbers (crashes on 4.7) #11126
4.10: [release-4.10] Bug 2060448: Fix potential issues with namespaces that contains just numbers #11132
4.9: [release-4.9] Bug 2060449: Fix potential issues with namespaces that contains just numbers #11133
4.8: [release-4.8] Bug 2060450: Fix that the preferred namespace was not selected when it contains just numbers #11134
4.7: [release-4.7] Bug 2060451: Fix a crash when the preferred namespace contains just numbers #11135

openshift-ci · 2022-03-03T14:53:09Z

@jerolimov: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-03T14:58:36Z

@jerolimov: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karthikjeeyar · 2022-03-04T10:52:35Z

Verified using clusterbot.
I am not able to reproduce the issue with this changes.

/lgtm

openshift-bot · 2022-03-05T01:00:36Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-05T01:00:40Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-06T01:00:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-06T01:00:22Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-07T01:00:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-07T01:00:25Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-08T01:00:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-08T01:00:27Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-09T01:01:05Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-09T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-10T01:00:33Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-10T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-11T01:00:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-11T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2022-03-28T08:05:21Z

/approve

invincibleJai · 2022-03-28T08:08:38Z

/cc @rohitkrai03

rohitkrai03

/approve

openshift-ci · 2022-03-28T11:30:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, karthikjeeyar, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-03-29T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-29T01:01:19Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-30T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-30T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-31T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-31T01:01:26Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-01T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-01T01:01:41Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-02T01:00:55Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-02T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-03T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-03T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-04T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-04T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is invalid:

expected dependent Bugzilla bug 2060450 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-05T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-05T01:01:53Z

@openshift-bot: This pull request references Bugzilla bug 2060451, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2060450 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2060450 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jrichter1 · 2022-04-07T08:57:57Z

/label cherry-pick-approved

openshift-ci · 2022-04-07T10:53:53Z

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-04-07T10:55:36Z

@jerolimov: All pull requests linked via external trackers have merged:

openshift/console#11135

Bugzilla bug 2060451 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fix an issue with namespaces that contains just numbers

276f15c

openshift-ci bot requested a review from karthikjeeyar March 3, 2022 14:52

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 3, 2022

openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared labels Mar 3, 2022

jerolimov changed the title ~~[release-4.7] Bug 2060451: Fix an issue with namespaces that contains just numbers~~ [release-4.7] Bug 2060451: Fix a crash when the preferred namespace contains just numbers Mar 3, 2022

openshift-ci bot assigned karthikjeeyar Mar 4, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022

openshift-ci bot requested a review from rohitkrai03 March 28, 2022 08:08

rohitkrai03 approved these changes Mar 28, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 5, 2022

openshift-ci bot requested a review from sanketpathak April 5, 2022 01:01

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 7, 2022

openshift-merge-robot merged commit b023854 into openshift:release-4.7 Apr 7, 2022

[release-4.7] Bug 2060451: Fix a crash when the preferred namespace contains just numbers #11135

[release-4.7] Bug 2060451: Fix a crash when the preferred namespace contains just numbers #11135

Conversation

jerolimov commented Mar 3, 2022 • edited

openshift-ci bot commented Mar 3, 2022

openshift-ci bot commented Mar 3, 2022

karthikjeeyar commented Mar 4, 2022

openshift-bot commented Mar 5, 2022

openshift-ci bot commented Mar 5, 2022

openshift-bot commented Mar 6, 2022

openshift-ci bot commented Mar 6, 2022

openshift-bot commented Mar 7, 2022

openshift-ci bot commented Mar 7, 2022

openshift-bot commented Mar 8, 2022

openshift-ci bot commented Mar 8, 2022

openshift-bot commented Mar 9, 2022

openshift-ci bot commented Mar 9, 2022

openshift-bot commented Mar 10, 2022

openshift-ci bot commented Mar 10, 2022

openshift-bot commented Mar 11, 2022

openshift-ci bot commented Mar 11, 2022

invincibleJai commented Mar 28, 2022

invincibleJai commented Mar 28, 2022

rohitkrai03 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Mar 28, 2022

openshift-bot commented Mar 29, 2022

openshift-ci bot commented Mar 29, 2022

openshift-bot commented Mar 30, 2022

openshift-ci bot commented Mar 30, 2022

openshift-bot commented Mar 31, 2022

openshift-ci bot commented Mar 31, 2022

openshift-bot commented Apr 1, 2022

openshift-ci bot commented Apr 1, 2022

openshift-bot commented Apr 2, 2022

openshift-ci bot commented Apr 2, 2022

openshift-bot commented Apr 3, 2022

openshift-ci bot commented Apr 3, 2022

openshift-bot commented Apr 4, 2022

openshift-ci bot commented Apr 4, 2022

openshift-bot commented Apr 5, 2022

openshift-ci bot commented Apr 5, 2022

jrichter1 commented Apr 7, 2022

openshift-ci bot commented Apr 7, 2022

openshift-ci bot commented Apr 7, 2022

jerolimov commented Mar 3, 2022 •

edited