Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2062258: Add optional chaining to avoid npe #11164

Merged
merged 1 commit into from Mar 14, 2022
Merged

[release-4.10] Bug 2062258: Add optional chaining to avoid npe #11164

merged 1 commit into from Mar 14, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #11146

/assign karthikjeeyar

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 9, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2022

@openshift-cherrypick-robot: Bugzilla bug 2061333 has been cloned as Bugzilla bug 2062258. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2062258: Add optional chaining to avoid npe

In response to this:

[release-4.10] Bug 2061333: Add optional chaining to avoid npe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 2061333: Add optional chaining to avoid npe [release-4.10] Bug 2062258: Add optional chaining to avoid npe Mar 9, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2062258, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2061333 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2061333 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.10] Bug 2062258: Add optional chaining to avoid npe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak March 9, 2022 12:56
@karthikjeeyar
Copy link
Contributor

/approved

@karthikjeeyar
Copy link
Contributor

/assign @vikram-raj

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Mar 9, 2022
vikram-raj
vikram-raj approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, openshift-cherrypick-robot, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@karthikjeeyar
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@karthikjeeyar: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 11, 2022
@sanketpathak
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 14, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7f54212 into openshift:release-4.10 Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2062258 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2062258: Add optional chaining to avoid npe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj approved these changes

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@rottencandy rottencandy Awaiting requested review from rottencandy

Assignees

@vikram-raj vikram-raj

@karthikjeeyar karthikjeeyar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/pipelines Related to pipelines-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @karthikjeeyar @jerolimov @sanketpathak @openshift-bot @vikram-raj @openshift-merge-robot