Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2079673: disable migrated components #11205

Merged
merged 1 commit into from Apr 28, 2022
Merged

Bug 2079673: disable migrated components #11205

merged 1 commit into from Apr 28, 2022

Conversation

SanjalKatiyar
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Mar 21, 2022
@afreen23
Copy link
Contributor

Lets merge it after enabling red-hat-storage/odf-console#152

@SanjalKatiyar
Copy link
Contributor Author

/test ceph-storage-plugin

@SanjalKatiyar SanjalKatiyar changed the title disable wizard flow from console disable migrated components Apr 25, 2022
@SanjalKatiyar
Copy link
Contributor Author

/test ceph-storage-plugin

SanjalKatiyar
SanjalKatiyar commented Apr 26, 2022
View reviewed changes
frontend/packages/ceph-storage-plugin/src/plugin.ts
Comment on lines +169 to +171
flags: {
disallowed: [FEATURES.ODF_WIZARD],
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

bipuladh
bipuladh approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@SanjalKatiyar SanjalKatiyar changed the title disable migrated components Bug 2079673: disable migrated components Apr 28, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

@SanjalKatiyar: This pull request references Bugzilla bug 2079673, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2079673: disable migrated components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

@SanjalKatiyar: This pull request references Bugzilla bug 2079673, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Contributor Author

/retest

@SanjalKatiyar
Copy link
Contributor Author

/test ceph-storage-plugin
/test e2e-gcp-console

1 similar comment
@SanjalKatiyar
Copy link
Contributor Author

/test ceph-storage-plugin
/test e2e-gcp-console

@SanjalKatiyar
Copy link
Contributor Author

/test ceph-storage-plugin

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@SanjalKatiyar
Copy link
Contributor Author

/test ceph-storage-plugin

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

@SanjalKatiyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit dc6ecb3 into openshift:master Apr 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

@SanjalKatiyar: All pull requests linked via external trackers have merged:

Bugzilla bug 2079673 has been moved to the MODIFIED state.

In response to this:

Bug 2079673: disable migrated components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh approved these changes

@afreen23 afreen23 Awaiting requested review from afreen23

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SanjalKatiyar @afreen23 @openshift-bot @bipuladh @openshift-merge-robot