New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] Bug 2066771: Enhance Insights widget empty states #11218
[release-4.9] Bug 2066771: Enhance Insights widget empty states #11218
Conversation
Make sure the Insights Advisor widget in the main dashboard requests for the Insights Operator status Prometheus metric to decide whether the Insights Operator is disabled. As a side-work, the patch improves empty states handling (disabled, waiting for results, error). Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2066771.
@gkarat: This pull request references Bugzilla bug 2066771, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
/test e2e-gcp-console |
@gkarat: An error was encountered querying GitHub for users with public email (ireyes@redhat.com) for bug 2066771 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gkarat: An error was encountered querying GitHub for users with public email (ireyes@redhat.com) for bug 2066771 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gkarat: This pull request references Bugzilla bug 2066771, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ireyes@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett, hello Sam, here is a patch backporting (4.9.z) one of the features introduced 1-2 months ago (Insights Advisor widget on the main console dashboard). Could you please take a look? 👋🏼 |
@spadgett, ping 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label backport-risk-assessed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gkarat, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
/label cherry-pick-approved |
@gkarat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@gkarat: All pull requests linked via external trackers have merged: Bugzilla bug 2066771 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a manual cherry-pick of #10826.
Description:
Make sure the Insights Advisor widget in the main dashboard requests for the Insights Operator status Prometheus metric to decide whether the Insights Operator is disabled. As a side-work, the patch improves empty states handling (disabled, waiting for results, error).
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2066771.
/assign @spadgett
/cc: @tremes