Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2066771: Enhance Insights widget empty states #11218

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Mar 22, 2022

This is a manual cherry-pick of #10826.

Description:

Make sure the Insights Advisor widget in the main dashboard requests for the Insights Operator status Prometheus metric to decide whether the Insights Operator is disabled. As a side-work, the patch improves empty states handling (disabled, waiting for results, error).

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2066771.

/assign @spadgett
/cc: @tremes

Make sure the Insights Advisor widget in the main dashboard requests
for the Insights Operator status Prometheus metric to decide whether
the Insights Operator is disabled. As a side-work, the patch improves
empty states handling (disabled, waiting for results, error).

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2066771.
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2022

@gkarat: This pull request references Bugzilla bug 2066771, which is invalid:

  • expected the bug to target the "4.9.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2066771: Enhance Insights widget empty states

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from tisnik and zherman0 March 22, 2022 16:24
@openshift-ci openshift-ci bot added component/insights Related to insights plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2022
@gkarat
Copy link
Contributor Author

gkarat commented Mar 23, 2022

/bugzilla refresh

@gkarat
Copy link
Contributor Author

gkarat commented Mar 23, 2022

/test e2e-gcp-console

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

@gkarat: An error was encountered querying GitHub for users with public email (ireyes@redhat.com) for bug 2066771 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Mar 23, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

@gkarat: An error was encountered querying GitHub for users with public email (ireyes@redhat.com) for bug 2066771 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Mar 23, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

@gkarat: This pull request references Bugzilla bug 2066771, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2039868 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2039868 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ireyes@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkarat
Copy link
Contributor Author

gkarat commented Mar 23, 2022

@spadgett, hello Sam, here is a patch backporting (4.9.z) one of the features introduced 1-2 months ago (Insights Advisor widget on the main console dashboard). Could you please take a look? 👋🏼

@gkarat
Copy link
Contributor Author

gkarat commented Apr 6, 2022

@spadgett, ping 👀

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkarat, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ikerreyes
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 21, 2022
@ikerreyes
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2022

@gkarat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 446f15b into openshift:release-4.9 Apr 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2022

@gkarat: All pull requests linked via external trackers have merged:

Bugzilla bug 2066771 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2066771: Enhance Insights widget empty states

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/insights Related to insights plugin lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants