Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation of Pipeline Actions #11238

Merged
merged 1 commit into from Mar 31, 2022
Merged

Automation of Pipeline Actions #11238

merged 1 commit into from Mar 31, 2022

Conversation

hemantsaini-7
Copy link
Contributor

Description:

Jira Id: ODC-6589

Pre-conditions/setup:

Checks for approving Epic scenarios Automation PR:

  • Execute the @to-do tagged gherkin scripts manually
  • Convert the @to-do gherkin scripts to cypress automation scripts
  • Once scripts are automated, replace tag @to-do with @epic-number
  • Execute the scripts in Remote cluster

Refactoring criteria for approving Automation PR:

Execution Commands:
Example:

    export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
    BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
    BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.8-042801.devcluster.openshift.com
    export BRIDGE_KUBEADMIN_PASSWORD
    export BRIDGE_BASE_ADDRESS
    oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
    oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
    oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
    ./test-cypress.sh -p pipelines

Screen shots:
image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/pipelines Related to pipelines-plugin labels Mar 28, 2022
@jrichter1
Copy link
Contributor

@hemantsaini-7 can you make it so only the last commit is part of this PR, or does it depend on #11220 ?

jrichter1
jrichter1 reviewed Mar 30, 2022
View reviewed changes
...s/pipelines-plugin/integration-tests/support/step-definitions/pipelines/pipelines-actions.ts Outdated
@@ -242,3 +242,51 @@ Then('user will be redirected to Pipelines page', () => {
When('user clicks Save button on Pipeline Builder page', () => {
pipelineBuilderPage.clickSaveButton();
});

And('user clicks on Add task button', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Given/When/Then for step implementation.

@hemantsaini-7 hemantsaini-7 force-pushed the pipeline-actions branch 2 times, most recently from 2ab1361 to 8f00e9e Compare March 30, 2022 14:30
@hemantsaini-7
Copy link
Contributor Author

/retest

@hemantsaini-7
Copy link
Contributor Author

/assign jrichter1

jrichter1
jrichter1 reviewed Mar 31, 2022
View reviewed changes
...tend/packages/pipelines-plugin/integration-tests/features/pipelines/pipeline-metrics.feature Outdated
Scenario: No datapoint graphs in metrics tab: P-04-TC03
Given pipeline "pipeline-metrics-two" is present on Pipeline Details page
When user clicks on pipeline "pipeline-metrics-two"
And user selects option "Start" from Actions menu drop down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you removed the When clause, please add it to the next line, so we keep the given-when-then format

jrichter1
jrichter1 reviewed Mar 31, 2022
View reviewed changes
...end/packages/pipelines-plugin/integration-tests/features/pipelines/pipelines-actions.feature Outdated
@@ -86,14 +86,14 @@ Feature: Perform the actions on Pipelines page
| pipelines-ccc |


@to-do
@regression
Scenario Outline: Add the task by editing the pipeline: P-06-TC08
Given pipeline "<pipeline_name>" is present on Pipelines page
When user selects "Edit Pipeline" option from kebab menu of "<pipeline_name>"
When user clicks on Add task in parallel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed there are 2 When lines, can you change the second one to And to keep it consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done!

jrichter1
jrichter1 reviewed Mar 31, 2022
View reviewed changes
...s/pipelines-plugin/integration-tests/support/step-definitions/pipelines/pipelines-actions.ts Outdated
.click({ force: true });
});

Then('user clicks on Add in {string} task', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parameter is not being used, looks like it doesn't need to be there

@jrichter1
Copy link
Contributor

Screenshot from 2022-03-31 16-37-37

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hemantsaini-7, jrichter1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@jrichter1
Copy link
Contributor

This PR only affects our tests.
/label px-approved
/label docs-approved
/label qe-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Mar 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit c6494b0 into openshift:master Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

@hemantsaini-7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrichter1 jrichter1 jrichter1 left review comments

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@jrichter1 jrichter1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hemantsaini-7 @jrichter1 @openshift-merge-robot