Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data #11270

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #11226

/assign vikram-raj

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@openshift-cherrypick-robot: Bugzilla bug 2067983 has been cloned as Bugzilla bug 2070827. Retitling PR to link against new bug.
/retitle [release-4.9] [release-4.10] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data

In response to this:

[release-4.9] [release-4.10] Bug 2067983: Pipeline metrics: use prometheus-tenancy API to get data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] [release-4.10] Bug 2067983: Pipeline metrics: use prometheus-tenancy API to get data [release-4.9] [release-4.10] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data Apr 1, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2070827, which is invalid:

  • expected dependent Bugzilla bug 2067983 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] [release-4.10] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Apr 1, 2022
@vikram-raj
Copy link
Member

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link
Author

@vikram-raj: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/retitle [release-4.9] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data
/bugzilla refresh

@openshift-ci openshift-ci bot changed the title [release-4.9] [release-4.10] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data [release-4.9] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data Apr 25, 2022
@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

@jerolimov: This pull request references Bugzilla bug 2070827, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2067983 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2067983 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/retitle [release-4.9] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT tested on a cluster. But change looks fine if its works.

/label backport-risk-assessed
/approve

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2022
@karthikjeeyar
Copy link
Contributor

Verified in clusterbot, users with view permission on their namespace and openshift-pipelines is able to see the metrics

image

Rolebindings attached to consoledeveloper user:
Screenshot 2022-04-26 at 1 53 33 PM

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, karthikjeeyar, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanketpathak
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 26, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ff68590 into openshift:release-4.9 Apr 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2070827 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2070827: Pipeline metrics: use prometheus-tenancy API to get data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Author

@vikram-raj: #11270 failed to apply on top of branch "release-4.8":

Applying: Pipeline metrics: use prometheus-tenancy API to get data
Using index info to reconstruct a base tree...
M	frontend/packages/pipelines-plugin/src/components/pipelines/const.ts
M	frontend/packages/pipelines-plugin/src/components/pipelines/hooks.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelines/hooks.ts
CONFLICT (content): Merge conflict in frontend/packages/pipelines-plugin/src/components/pipelines/hooks.ts
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelines/const.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Pipeline metrics: use prometheus-tenancy API to get data
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member

Created a manual cherry-pick PR #11409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/pipelines Related to pipelines-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants