Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create single script for e2e tests for setup, launch, and teardown #1136

Merged
merged 1 commit into from
Jan 28, 2019
Merged

create single script for e2e tests for setup, launch, and teardown #1136

merged 1 commit into from
Jan 28, 2019

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Jan 24, 2019 •
edited

Add a script for e2e tests. Setup, launch, and then copy screenshots to the artifacts dir.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2019
spadgett
spadgett reviewed Jan 24, 2019
View reviewed changes
test-gui.sh Outdated Show resolved Hide resolved
spadgett
spadgett reviewed Jan 24, 2019
View reviewed changes
test-gui-e2e-teardown.sh Outdated Show resolved Hide resolved
@spadgett
Copy link
Member

I'd suggest adding a prow-e2e.sh script that wraps test-gui.sh and does both set up and teardown. Then we can update openshift/release to call prow-e2e.sh and remove the old setup script when the release repo PR merges. I think that will be cleaner in the long run.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2019
@jcaianirh jcaianirh changed the title create teardown script for e2e tests WIP: create teardown script for e2e tests Jan 25, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2019
@jcaianirh jcaianirh changed the title WIP: create teardown script for e2e tests WIP: create single script for e2e tests for setup, launch, and teardown Jan 28, 2019
spadgett
spadgett approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Feel free to remove the hold when done testing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2019
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 28, 2019
@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@jcaianirh jcaianirh changed the title WIP: create single script for e2e tests for setup, launch, and teardown create single script for e2e tests for setup, launch, and teardown Jan 28, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2019
@jcaianirh
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2154628 into openshift:master Jan 28, 2019
@jcaianirh jcaianirh mentioned this pull request Jan 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcaianirh @spadgett @openshift-ci-robot @openshift-merge-robot