New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2076690: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings #11362

Merged

openshift-merge-robot merged 1 commit into openshift:release-4.9 from openshift-cherrypick-robot:cherry-pick-11297-to-release-4.9

Jun 1, 2022

openshift-cherrypick-robot commented Apr 19, 2022

This is an automated cherry-pick of #11297

/assign rhamilto


          Bug 2071599: fix bug where RoleBindings are not displaying in Cluster…

6f4d213

…Role > RoleBindings

openshift-cherrypick-robot mentioned this pull request

[release-4.10] Bug 2072839: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings #11297

Merged

openshift-ci bot assigned rhamilto

Contributor

openshift-ci bot commented Apr 19, 2022

@openshift-cherrypick-robot: Bugzilla bug 2072839 has been cloned as Bugzilla bug 2076690. Retitling PR to link against new bug.
/retitle [release-4.9] [release-4.10] Bug 2076690: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings

In response to this:

[release-4.9] [release-4.10] Bug 2072839: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot changed the title ~~[release-4.9] [release-4.10] Bug 2072839: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings~~ [release-4.9] [release-4.10] Bug 2076690: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings

openshift-ci bot added bugzilla/severity-medium bugzilla/valid-bug labels

Contributor

openshift-ci bot commented Apr 19, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2076690, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2072839 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2072839 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (scolange@redhat.com), skipping review request.

In response to this:

[release-4.9] [release-4.10] Bug 2076690: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from dtaylor113 and jcaianirh

April 19, 2022 16:38

openshift-ci bot added the component/core label

rhamilto changed the title ~~[release-4.9] [release-4.10] Bug 2076690: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings~~ [release-4.9] Bug 2076690: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings

Member

rhamilto commented Apr 19, 2022

/label backport-risk-assessed

/lgtm

openshift-ci bot added backport-risk-assessed lgtm labels

Contributor

openshift-ci bot commented Apr 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

Contributor

openshift-bot commented Apr 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments

Contributor

openshift-bot commented Apr 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment

Contributor

openshift-bot commented Apr 20, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

yanpzhan commented Apr 22, 2022

@rhamilto QE tested against the pr, found the bug issue still exists. There is no rolebinding shown under "system:image-builder" role's "RoleBindings" tab.

Member

rhamilto commented Apr 22, 2022

Good catch, @yanpzhan. It appears there is more to fixing this bug for 4.9 than this fix alone as I am not seeing RoleBindings for any Roles (e.g., admin or /k8s/cluster/clusterroles/admin/bindings). And reverting the changes in this PR have no effect, so I think the fix is valid, there are just other issues in 4.9 that need to be addressed.

/hold

openshift-ci bot added the do-not-merge/hold label

Member

rhamilto commented Apr 25, 2022

@yanpzhan, release-4.9 was missing #10846. A fix to add it to 4.9 has been opened with #11392. Once #11392 merges, please retest this PR. I tested both fixes locally against at 4.9.30 cluster-bot cluster, and everything is behaving as expected. cc: @cyril-ui-developer

Contributor

yapei commented Apr 28, 2022

@scolange please help check again, thanks!

scolange commented May 11, 2022

/label qe-approved

openshift-ci bot added the qe-approved label

Contributor

yanpzhan commented May 12, 2022 •

edited

The bug is fixed.
/label cherry-pick-approved

Contributor

yanpzhan commented May 12, 2022

/label cherry-pick-approved

openshift-ci bot added the cherry-pick-approved label

XiyunZhao mentioned this pull request

[release-4.9] Bug 2079231: fix bug where ClusterRole > RoleBindings did not display… #11405

Merged

Member

rhamilto commented Jun 1, 2022

/hold cancel

openshift-ci bot removed the do-not-merge/hold label

Contributor

openshift-ci-robot commented Jun 1, 2022

/retest-required

Remaining retests: 2 against base HEAD 4b9d05d and 8 for PR HEAD 6f4d213 in total

Contributor

openshift-ci-robot commented Jun 1, 2022

/retest-required

Remaining retests: 1 against base HEAD 4b9d05d and 7 for PR HEAD 6f4d213 in total

Contributor

openshift-ci-robot commented Jun 1, 2022

/retest-required

Remaining retests: 0 against base HEAD 4b9d05d and 6 for PR HEAD 6f4d213 in total

Contributor

openshift-ci bot commented Jun 1, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit 13f73e9 into openshift:release-4.9

Contributor

openshift-ci bot commented Jun 1, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/console#11362

Bugzilla bug 2076690 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2076690: fix bug where RoleBindings are not displaying in ClusterRole > RoleBindings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved backport-risk-assessed bugzilla/severity-medium bugzilla/valid-bug cherry-pick-approved component/core lgtm qe-approved