Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-3090: [Dark Theme] Convert custom row-filter to use PatternFly ToggleGroup component for styling that is dark theme enabled. #11384

Merged

Conversation

sg00dwin
Copy link
Member

Since row-filter uses a toggle for filtering, I've converted it to use https://www.patternfly.org/v4/components/toggle-group/ styling.
cc @vikram-raj @mattnolting

before
Screen Shot 2022-04-22 at 10 11 58 AM
Screen Shot 2022-04-22 at 10 12 13 AM

after
filter-light
filter-dark

@sg00dwin
Copy link
Member Author

/label docs-approved
/label px-approved

We have docs- and px-approval for the epic.

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Apr 22, 2022
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Apr 22, 2022
@sg00dwin
Copy link
Member Author

QE Approver:
/assign @yanpzhan

@rhamilto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2022
@mattnolting
Copy link
Contributor

@sg00dwin This looks awesome!!! Great update. I noticed toggle group could potentially break some things when viewport width is limited or there are many items in the group, so I opened sg00dwin#5 to prevent unwanted layout adjustments.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@mattnolting
Copy link
Contributor

Fantastic!

/LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022

@mattnolting: changing LGTM is restricted to collaborators

In response to this:

Fantastic!

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin
Copy link
Member Author

@rhamilto mind retagging. Had to push some changes.

@rhamilto
Copy link
Member

Changes look good. Mind squashing?

@rhamilto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattnolting, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanpzhan
Copy link
Contributor

@sg00dwin launched a cluster against the pr, check on the binding api page, the "User" and "Group" box color is white, is it an issue?
Screenshot from 2022-04-26 16-48-47

@sg00dwin
Copy link
Member Author

@sg00dwin launched a cluster against the pr, check on the binding api page, the "User" and "Group" box color is white, is it an issue? Screenshot from 2022-04-26 16-48-47

@yanpzhan that issue will be fixed when #11370 merges. So I'll put a hold on this for now and re tag you once it's merged, so you can retest.

@sg00dwin sg00dwin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022
@sg00dwin sg00dwin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2022
@sg00dwin
Copy link
Member Author

Hi @yanpzhan #11370 has merged so this is ready for qe approval.

@sg00dwin
Copy link
Member Author

sg00dwin commented May 4, 2022

/assign @yapei for QE approval

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

@sg00dwin: GitHub didn't allow me to assign the following users: for, QE, approval.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @yapei for QE approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanpzhan
Copy link
Contributor

yanpzhan commented May 5, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c7cb0e3 into openshift:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants