New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-3090: [Dark Theme] Convert custom row-filter to use PatternFly ToggleGroup component for styling that is dark theme enabled. #11384
Conversation
/label docs-approved We have docs- and px-approval for the epic. |
QE Approver: |
/lgtm |
@sg00dwin This looks awesome!!! Great update. I noticed |
Fantastic! /LGTM |
@mattnolting: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto mind retagging. Had to push some changes. |
Changes look good. Mind squashing? |
… styling that is dark theme enabled.
24f5076
to
273d39e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattnolting, rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sg00dwin launched a cluster against the pr, check on the binding api page, the "User" and "Group" box color is white, is it an issue? |
/assign @yapei for QE approval |
@sg00dwin: GitHub didn't allow me to assign the following users: for, QE, approval. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label qe-approved |
@sg00dwin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Since row-filter uses a toggle for filtering, I've converted it to use https://www.patternfly.org/v4/components/toggle-group/ styling.
cc @vikram-raj @mattnolting
before
after