Refresh metrics when changing selected overview project #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
spadgett
force-pushed
the
overview-metrics-ns-change
branch
from
25daec0
to
0b5c574
Compare
openshift-ci-robot
added
size/S
spadgett
commented
Jan 25, 2019
| } | ||
|
|
||
| fetchMetrics(): void { | ||
| fetchMetrics = (): void => { |
There was a problem hiding this comment.
Using fat arrow to bind to this since we pass this.fetchMetrics directly to setTimeout below
|
/retest |
|
Deploy image flake /retest |
|
Install failed /retest |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.coreos.com/browse/CONSOLE-1235
/assign @TheRealJon
Thanks for catching this @robszumski