Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update engine check to allow node 11 #1142

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Update engine check to allow node 11 #1142

merged 1 commit into from
Jan 29, 2019

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Jan 28, 2019

Just a small detail on the README.
a bit of background...: was installing node on new HW and installed version 11. When I was installing glide the installment shouted on me that I need version 10.

@spadgett PTAL

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2019
@jhadvig jhadvig changed the title REAMDE - make node version more specific README - make node version more specific Jan 28, 2019
@spadgett
Copy link
Member

Can you paste the specific error?

I guess I'm unclear on how glide and the node version relate

@spadgett
Copy link
Member

I'm asking in part to see if we can fix console to work with newer node versions

@jhadvig
Copy link
Member Author

jhadvig commented Jan 28, 2019

@spadgett sorry, it was not glide but build.sh that was throwing following error:

 $ ./build.sh
~/go/src/github.com/openshift/console/frontend ~/go/src/github.com/openshift/console
yarn install v1.13.0
[1/5] 🔍  Validating package.json...
error @: The engine "node" is incompatible with this module. Expected version ">=8.x <=10.x". Got "11.8.0"
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

After checking the package.json I see that we are limiting the versions there.

@spadgett
Copy link
Member

Can we try this and see if things work with node 11?

"node": ">=8.x <=11.x"

@jhadvig
Copy link
Member Author

jhadvig commented Jan 28, 2019

on it !

@jhadvig jhadvig changed the title README - make node version more specific Update engine check to allow node 11 Jan 28, 2019
spadgett
spadgett approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@spadgett
Copy link
Member

/refresh

@spadgett
Copy link
Member

/test

@spadgett
Copy link
Member

Closing and reopening to kick the tests

@spadgett spadgett closed this Jan 29, 2019
@spadgett spadgett reopened this Jan 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit 123a010 into openshift:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhadvig @spadgett @openshift-ci-robot @openshift-merge-robot