Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark Theme]: fix quick search bar and project selector in User Preferences page #11447

Merged
merged 1 commit into from May 10, 2022

Conversation

vikram-raj
Copy link
Member

fixes: https://issues.redhat.com/browse/ODC-6634

Screnshots:

Project selector

Before:
image

After:
image

Quick Search

Before:
image

image

After:
image

image

@openshift-ci openshift-ci bot requested review from jhadvig and rhamilto May 6, 2022 07:42
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared labels May 6, 2022
@vikram-raj
Copy link
Member Author

cc: @sg00dwin @mattnolting

@vikram-raj
Copy link
Member Author

/cc @jerolimov

@openshift-ci openshift-ci bot requested a review from jerolimov May 6, 2022 07:43
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 👍

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@jerolimov
Copy link
Member

Propagating docs and px acks from the Epic
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels May 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 55d2a36 into openshift:master May 10, 2022
@vikram-raj vikram-raj deleted the odc-6634-2 branch May 10, 2022 04:27
jgbernalp pushed a commit to jgbernalp/console that referenced this pull request May 11, 2022
[Dark Theme]: fix quick search bar and  project selector in User Preferences page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants