Remove unused Jenkins and e2e scripts #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
|
@TheRealJon moved the console logging to a file as we spoke about. |
TheRealJon
reviewed
Jan 30, 2019
| @@ -56,23 +58,15 @@ export const config: Config = { | |||
| } | |||
| }, | |||
| onComplete: async() => { | |||
| console.log('BEGIN BROWSER LOGS'); | |||
| const consoleLogStream = createWriteStream('gui_test_screenshots/browser.log', { flags: 'a' }); | |||
| this.logToFile = function() { | |||
There was a problem hiding this comment.
Could probably just move this logic inline since it's only used in one place.
|
/test console-e2e |
|
/retest |
|
/test console-e2e |
1 similar comment
|
/test console-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused Jenkins and e2e scripts, and adjust the README.md. Also remove logging to console and add to a file called browser.log which resides in the gui_test_screenshots folder and gets copied to artifacts.