Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust placement of contextDir in buildConfig #1148

Merged

Conversation

rebeccaalpert
Copy link
Contributor

Moved contextDir from under git to source. ContextDir now shows up in the BuildConfig YAML.

Fixes bug 1669974.

Moved contextDir from under git to source. ContextDir now shows up in the BuildConfig YAML.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1669974
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good catch!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit ce7d427 into openshift:master Jan 29, 2019
@rebeccaalpert rebeccaalpert deleted the fix-missing-contextdir branch January 29, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants