Bug 2079845: fix catalog filter group getting removed on keyword change

[invincibleJai]

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2079845

Description:

The issue is with filter group and filters showing up and hiding based on filter count if user types as in below

Before:

After:

[openshift-ci]

@invincibleJai: This pull request references Bugzilla bug 2079845, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2079845: fix catalog filter group getting removed on keyword change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@invincibleJai: This pull request references Bugzilla bug 2079845, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2079845: fix catalog filter group getting removed on keyword change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/cc @serenamarie125 @jerolimov PTAL if above make sense

[openshift-ci]

@invincibleJai: GitHub didn't allow me to request PR reviews from the following users: make, sense, PTAL, if, above.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @serenamarie125 @jerolimov PTAL if above make sense

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[debsmita1]

The provider section shouldn't show up if there's only one provider present. So this looks good to me

[jerolimov]

/cc @serenamarie125 @jerolimov PTAL if above make sense

Shouldn't the Event Sink should collapse the left navbar similar to Devfiles? Otherwise this is fine for me.

[jerolimov]

/uncc

[openshift-ci]

@invincibleJai: This pull request references Bugzilla bug 2079845, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2079845: fix catalog filter group getting removed on keyword change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/cc @serenamarie125 @jerolimov PTAL if above make sense

Shouldn't the Event Sink should collapse the left navbar similar to Devfiles? Otherwise this is fine for me.

@jerolimov Yeah makes sense, even for one provider filter should be shown (as in here #11313 we are showing for bindable). In devfile it'll be the same i.e collapse as no filter/provider is defined in extensions. Have updated gifs as well in the PR description.

[jerolimov]

This shows the repo now also on the helm catalog. For me personally this is fine, but its exactly the opposite what the bug expected:

Expected results:
If all the event sinks in the catalog are coming from only one provider then hide the providers section

I would like to have @serenamarie125 or @beaumorley opinion here.

The question is should we show the provider here?

If yes this PR is fine. Otherwise should we then hide the complete left navigation? An empty navigation looks confusing.

And on Helm repo:

[serenamarie125]

LGTM!

Showing the provider if there is only one makes sense to me as it provides context. Especially since additional providers/registries can be added on the fly in many of the catalogs (devfiles, helm & here )

[jerolimov]

Thank you

/lgtm
/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [invincibleJai,jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@invincibleJai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@invincibleJai: All pull requests linked via external trackers have merged:

• openshift/console#11481

Bugzilla bug 2079845 has been moved to the MODIFIED state.

In response to this:

Bug 2079845: fix catalog filter group getting removed on keyword change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.