Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent initial scroll on operator hub page #1151

Merged

Conversation

jeff-phillips-18
Copy link
Member

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1669303
also fixes small issues:
filter by keyword include's the operator's name field
always show both install state filters
set the correct community operator support page link

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2019
Copy link
Contributor

@SamiSousa SamiSousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Jeff

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1669303
also fixes small issues:
  filter by keyword include's the operator's name field
  always show both install state filters
  set the correct community operator support page link
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2019
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3859bf7 into openshift:master Jan 30, 2019
@jeff-phillips-18 jeff-phillips-18 deleted the operator-hub branch November 19, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants