Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito #11519

vfreex · 2022-05-18T11:02:39Z

This is a manual cherry-pick of #11497.

Legacy Container First Pipeline will be deprecated on Jun 3, 2022. Images failing to migrate to the new source container workflow by this date will not have their sources shipped to customers and lose the compliance with legal requirements.

To move to the new source container workflow, we need to:

Eliminate use of distgit lookaside cache, which is not supported by the new workflow.
Use Cachito to track and provide npm dependencies.
Use fetch-artifacts-url.yaml to fetch binaries artifacts during the build.

Due to a limitation in Cachito, we also need to give a pseudo name and version to the frontend package. AFAIK the version doesn't need to be unique for every build.
I am not familiar with the code base. Let me know if the change is legitimate.

openshift-ci · 2022-05-18T11:02:41Z

@vfreex: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Eliminate use of lookaside cache and move to Cachito - 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vfreex · 2022-05-18T11:03:28Z

Similar to #11497, but for 4.6-4.9 because node-headers is needed in those versions.

vfreex · 2022-05-18T11:03:51Z

/cherry-pick release-4.8
/cherry-pick release-4.7
/cherry-pick release-4.6

openshift-cherrypick-robot · 2022-05-18T11:03:53Z

@vfreex: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8
/cherry-pick release-4.7
/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vfreex · 2022-05-18T12:11:31Z

Test build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=45394664

[Legacy Container First Pipeline][1] will be deprecated on Jun 3, 2022. Images failing to migrate to the new source container workflow by this date will not have their sources shipped to customers and lose the compliance with legal requirements. To move to the new source container workflow, we need to: - Eliminate use of distgit lookaside cache, which is not supported by the new workflow. - Use [Cachito][2] to track and provide npm dependencies. - Use [fetch-artifacts-url.yaml][3] to fetch binaries artifacts during the build. Due to a limitation in Cachito, we also need to give a pseudo name and version to the frontend package. AFAIK the version doesn't need to be unique for every build. I am not familiar with the code base. Let me know if the change is legitimate. [1]: https://docs.engineering.redhat.com/display/SP/Decommission+of+Legacy+Container+First+Pipeline [2]: https://github.com/containerbuildsystem/cachito [3]: https://osbs.readthedocs.io/en/osbs_ocp3/users.html#fetch-artifacts-url-yaml

openshift-ci · 2022-05-19T04:44:59Z

@vfreex: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Eliminate use of lookaside cache and move to Cachito

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vfreex · 2022-05-19T04:45:32Z

/retest

openshift-ci · 2022-05-19T05:10:06Z

@vfreex: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Eliminate use of lookaside cache and move to Cachito

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-05-19T05:32:37Z

@vfreex: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-cherrypick-robot · 2022-05-19T05:39:47Z

@vfreex: once the present PR merges, I will cherry-pick it on top of release-4.7 release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.7 release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vfreex · 2022-05-19T05:41:00Z

/cherry-pick release-4.7

openshift-cherrypick-robot · 2022-05-19T05:41:01Z

@vfreex: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vfreex · 2022-05-19T05:41:04Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2022-05-19T05:41:05Z

@vfreex: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-05-24T07:16:33Z

@vfreex: This pull request references Bugzilla bug 2089546, which is invalid:

expected dependent Bugzilla bug 2088304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 2089547 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2088304 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vfreex · 2022-05-24T07:16:38Z

/bugzilla refresh

openshift-ci · 2022-05-24T07:16:42Z

@vfreex: This pull request references Bugzilla bug 2089546, which is invalid:

expected dependent Bugzilla bug 2088304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 2089547 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2088304 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jupierce · 2022-05-24T22:49:19Z

This change was approved by Sam for 4.11, so I'm helping it along to unblock ART.

jupierce · 2022-05-24T22:49:25Z

/lgtm

openshift-ci · 2022-05-24T22:49:47Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jupierce, vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vfreex · 2022-05-25T00:06:36Z

/bugzilla refresh

openshift-ci · 2022-05-25T00:06:40Z

@vfreex: This pull request references Bugzilla bug 2089546, which is invalid:

expected dependent Bugzilla bug 2089547 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-05-25T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-05-25T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 2089546, which is invalid:

expected dependent Bugzilla bug 2089547 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vfreex · 2022-05-25T09:13:20Z

/bugzilla refresh

openshift-ci · 2022-05-25T09:13:27Z

@vfreex: This pull request references Bugzilla bug 2089546, which is invalid:

expected dependent Bugzilla bug 2089547 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jupierce · 2022-05-25T16:02:06Z

/bugzilla refresh

openshift-ci · 2022-05-25T16:02:10Z

@jupierce: This pull request references Bugzilla bug 2089546, which is invalid:

expected dependent Bugzilla bug 2089547 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jupierce · 2022-05-25T16:04:25Z

These are non functional changes and must merge as soon as we can get them in for compliance reasons. Overriding valid bug.

openshift-ci · 2022-05-25T16:09:19Z

@vfreex: All pull requests linked via external trackers have merged:

Bugzilla bug 2089546 has been moved to the MODIFIED state.

In response to this:

Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-05-25T16:09:55Z

@vfreex: new pull request created: #11573

In response to this:

/cherry-pick release-4.8
/cherry-pick release-4.7
/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-05-25T16:10:38Z

@vfreex: new pull request created: #11574

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-05-25T16:11:19Z

@vfreex: #11519 failed to apply on top of branch "release-4.6":

Applying: Eliminate use of lookaside cache and move to Cachito
Using index info to reconstruct a base tree...
M	Dockerfile.product
M	frontend/package.json
M	frontend/packages/console-plugin-sdk/src/codegen/plugin-resolver.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/console-plugin-sdk/src/codegen/plugin-resolver.ts
Auto-merging frontend/package.json
Auto-merging Dockerfile.product
CONFLICT (content): Merge conflict in Dockerfile.product
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Eliminate use of lookaside cache and move to Cachito
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from christianvogt and dtaylor113 May 18, 2022 11:03

openshift-ci bot added the component/sdk Related to console-plugin-sdk label May 18, 2022

vfreex force-pushed the use-cachito-4.9 branch from e43e6e7 to 908ce33 Compare May 19, 2022 03:40

vfreex changed the title ~~Eliminate use of lookaside cache and move to Cachito - 4.9~~ [release-4.9] Eliminate use of lookaside cache and move to Cachito May 19, 2022

vfreex changed the title ~~[release-4.9] Eliminate use of lookaside cache and move to Cachito~~ Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito May 24, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 24, 2022

vfreex mentioned this pull request May 24, 2022

[release-4.10] Bug 2089547: Eliminate use of lookaside cache and move to Cachito #11551

Merged

openshift-ci bot assigned jupierce May 24, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022

jupierce added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 25, 2022

openshift-merge-robot merged commit c28f128 into openshift:release-4.9 May 25, 2022

openshift-cherrypick-robot mentioned this pull request May 25, 2022

[release-4.8] Bug 2089725: Eliminate use of lookaside cache and move to Cachito #11573

Merged

openshift-cherrypick-robot mentioned this pull request May 25, 2022

[release-4.7] Bug 2090384: Eliminate use of lookaside cache and move to Cachito #11574

Merged

vfreex mentioned this pull request May 26, 2022

[openshift-4.9] ose-console: Get rid of distgit lookaside cache openshift-eng/ocp-build-data#1638

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito #11519

Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito #11519

vfreex commented May 18, 2022 •

edited

openshift-ci bot commented May 18, 2022

vfreex commented May 18, 2022

vfreex commented May 18, 2022

openshift-cherrypick-robot commented May 18, 2022

vfreex commented May 18, 2022

openshift-ci bot commented May 19, 2022

vfreex commented May 19, 2022

openshift-ci bot commented May 19, 2022

openshift-ci bot commented May 19, 2022

openshift-cherrypick-robot commented May 19, 2022

vfreex commented May 19, 2022

openshift-cherrypick-robot commented May 19, 2022

vfreex commented May 19, 2022

openshift-cherrypick-robot commented May 19, 2022

openshift-ci bot commented May 24, 2022

vfreex commented May 24, 2022

openshift-ci bot commented May 24, 2022

jupierce commented May 24, 2022

jupierce commented May 24, 2022

openshift-ci bot commented May 24, 2022

vfreex commented May 25, 2022

openshift-ci bot commented May 25, 2022

openshift-bot commented May 25, 2022

openshift-ci bot commented May 25, 2022

vfreex commented May 25, 2022

openshift-ci bot commented May 25, 2022

jupierce commented May 25, 2022

openshift-ci bot commented May 25, 2022

jupierce commented May 25, 2022

openshift-ci bot commented May 25, 2022

openshift-cherrypick-robot commented May 25, 2022

openshift-cherrypick-robot commented May 25, 2022

openshift-cherrypick-robot commented May 25, 2022

Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito #11519

Bug 2089546: [release-4.9] Eliminate use of lookaside cache and move to Cachito #11519

Conversation

vfreex commented May 18, 2022 • edited

openshift-ci bot commented May 18, 2022

vfreex commented May 18, 2022

vfreex commented May 18, 2022

openshift-cherrypick-robot commented May 18, 2022

vfreex commented May 18, 2022

openshift-ci bot commented May 19, 2022

vfreex commented May 19, 2022

openshift-ci bot commented May 19, 2022

openshift-ci bot commented May 19, 2022

openshift-cherrypick-robot commented May 19, 2022

vfreex commented May 19, 2022

openshift-cherrypick-robot commented May 19, 2022

vfreex commented May 19, 2022

openshift-cherrypick-robot commented May 19, 2022

openshift-ci bot commented May 24, 2022

vfreex commented May 24, 2022

openshift-ci bot commented May 24, 2022

jupierce commented May 24, 2022

jupierce commented May 24, 2022

openshift-ci bot commented May 24, 2022

vfreex commented May 25, 2022

openshift-ci bot commented May 25, 2022

openshift-bot commented May 25, 2022

openshift-ci bot commented May 25, 2022

vfreex commented May 25, 2022

openshift-ci bot commented May 25, 2022

jupierce commented May 25, 2022

openshift-ci bot commented May 25, 2022

jupierce commented May 25, 2022

openshift-ci bot commented May 25, 2022

openshift-cherrypick-robot commented May 25, 2022

openshift-cherrypick-robot commented May 25, 2022

openshift-cherrypick-robot commented May 25, 2022

vfreex commented May 18, 2022 •

edited