Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Bar for ClusterServiceVersion List View #1155

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

alecmerdler
Copy link
Contributor

Description

The OperatorGroups feature of OLM allows a single Operator to be installed into a single namespace and have its APIs provided to many other namespaces. To improve usability, the ClusterServiceVersion is "copied" into those target namespaces (but no Deployment is created). Adding a simple filter bar to the list view makes it easier to find "real" ClusterServiceVersion vs "copied" ones.

Also adds RBAC check for Operator-provided APIs and fixes PackageManifest rows with no channels.

Screenshots

ClusterServiceVersion list view (unfiltered):
screenshot_20190130_105850

ClusterServiceVersion list view (filtered):
screenshot_20190130_105934

Addresses https://jira.coreos.com/browse/ALM-880
Addresses https://jira.coreos.com/browse/ALM-8887
Addresses https://jira.coreos.com/browse/ALM-861

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2019
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecmerdler
Copy link
Contributor Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@openshift-merge-robot openshift-merge-robot merged commit ceffd5a into openshift:master Jan 31, 2019
@alecmerdler alecmerdler deleted the ALM-880 branch February 26, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants