Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.10] Bug 2089589: add debounce to tektonhub versions api call to avoid many calls #11552

Merged

Conversation

karthikjeeyar
Copy link
Contributor

Fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=2089589

Analysis / Root cause:

In pipeline builder, when the users types a task name quickly eg: "buildah" then there are equal amount of API calls per keystroke.

Solution Description:

Added a debounce in version fetch method, so the API calls will not be made frequently.

Screen shots / Gifs for design review:

Versions_api_debounced.mov

Unit test coverage report:

 CTA button tests
  ✓ Add button should be disabled if the versions is not available (89ms)
  ✓ Add button should be enabled if the versions is not available in the user created task (79ms)

Fetching Versions API
  ✓ should not call the versions API multiple times for the same task (30ms)
  ✓ should call the versions API multiple times for different task (52ms)

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

@karthikjeeyar: This pull request references Bugzilla bug 2089589, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2076527 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2076527 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2089589: [release -4.10] add debounce to tektonhub versions api call to avoid many calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2022
@karthikjeeyar
Copy link
Contributor Author

/assign @jerolimov

1 similar comment
@karthikjeeyar
Copy link
Contributor Author

/assign @jerolimov

@jerolimov
Copy link
Member

/retitle [release-4.10] Bug 2089589: add debounce to tektonhub versions api call to avoid many calls

@openshift-ci openshift-ci bot changed the title Bug 2089589: [release -4.10] add debounce to tektonhub versions api call to avoid many calls [release-4.10] Bug 2089589: add debounce to tektonhub versions api call to avoid many calls May 31, 2022
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar but not the same as in 4.11. Tested this branch on my CRC and it works fine.

/lgtm
/approve
/labe backport-risk-assessed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@invincibleJai
Copy link
Member

/label backport-risk-assessed

readded as there was typo above

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 1, 2022
@invincibleJai
Copy link
Member

/cc @sanketpathak

@sanketpathak
Copy link
Contributor

Verified on cluster-bot
Screenshot from 2022-06-08 14-56-03
/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 8, 2022
@invincibleJai
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 53d6dea and 8 for PR HEAD c7ed7e5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 53d6dea and 7 for PR HEAD c7ed7e5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 53d6dea and 6 for PR HEAD c7ed7e5 in total

@karthikjeeyar
Copy link
Contributor Author

/test e2e-gcp-console

@karthikjeeyar
Copy link
Contributor Author

/retest

1 similar comment
@karthikjeeyar
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@divyanshiGupta
Copy link
Contributor

/retest

2 similar comments
@karthikjeeyar
Copy link
Contributor Author

/retest

@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 50ae0c3 and 8 for PR HEAD b39cee8 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@karthikjeeyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 05ce36e into openshift:release-4.10 Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@karthikjeeyar: All pull requests linked via external trackers have merged:

Bugzilla bug 2089589 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2089589: add debounce to tektonhub versions api call to avoid many calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/pipelines Related to pipelines-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants