New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.10] Bug 2089589: add debounce to tektonhub versions api call to avoid many calls #11552
[release-4.10] Bug 2089589: add debounce to tektonhub versions api call to avoid many calls #11552
Conversation
@karthikjeeyar: This pull request references Bugzilla bug 2089589, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c754167
to
c7ed7e5
Compare
/assign @jerolimov |
1 similar comment
/assign @jerolimov |
/retitle [release-4.10] Bug 2089589: add debounce to tektonhub versions api call to avoid many calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar but not the same as in 4.11. Tested this branch on my CRC and it works fine.
/lgtm
/approve
/labe backport-risk-assessed
/label backport-risk-assessed readded as there was typo above |
/cc @sanketpathak |
/retest |
/test e2e-gcp-console |
/retest |
1 similar comment
/retest |
c7ed7e5
to
b39cee8
Compare
/retest |
2 similar comments
/retest |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@karthikjeeyar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@karthikjeeyar: All pull requests linked via external trackers have merged: Bugzilla bug 2089589 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2089589
Analysis / Root cause:
In pipeline builder, when the users types a task name quickly eg: "buildah" then there are equal amount of API calls per keystroke.
Solution Description:
Added a debounce in version fetch method, so the API calls will not be made frequently.
Screen shots / Gifs for design review:
Versions_api_debounced.mov
Unit test coverage report:
Browser conformance: