[release-4.9] Bug 2084028: Improve Firehose cache, fix broken import

[jerolimov]

Fix imports that are wrongly changed with backport PR #11476

Reverts this change in backport PR #11476:

The result is that the cache symbol is undefined. It looks like the caching still works fine, but in theory, this could reopen the bug #11256. The specific issue when importing an application is fixed in #11476

---

yarn build on release-4.9

yarn dev-once on release-4.9

yarn build with this PR

yarn dev-once with this PR

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/uncc rhamilto TheRealJon
/cc @rottencandy @invincibleJai

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/bugzilla refresh

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2077641 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2077641 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/retest
/bugzilla refresh

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2077641 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2077641 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/retest
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 4b9d05d and 8 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 4b9d05d and 7 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4b9d05d and 6 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 4b9d05d and 8 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 4b9d05d and 7 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4b9d05d and 6 for PR HEAD e9bed77 in total

[jerolimov]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 13f73e9 and 5 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 13f73e9 and 4 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 13f73e9 and 3 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 742f383 and 2 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 742f383 and 1 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 742f383 and 0 for PR HEAD e9bed77 in total

[openshift-ci-robot]

/hold

Revision e9bed77 was retested 9 times: holding

[openshift-ci]

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jerolimov]

Fixed the unit tests

/unhold

[rottencandy]

Tested topology load on cluster, works fine.
/lgtm

0.mp4

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [invincibleJai,jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rottencandy]

I noticed that the topology force layout stops updating for some reason, although I'm sure it's not related to this PR.

1.mp4

[openshift-ci]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#11476
• openshift/console#11554

Bugzilla bug 2084028 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, fix broken import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.