Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where .co-m-horizontal-nav__menu__secondary does not scroll i… #1159

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

rhamilto
Copy link
Member

…n Chrome 70 Windows

Fixes https://jira.coreos.com/browse/CONSOLE-1048

It turns out in Windows that if the scrollbar isn't allowed to render, scrolling cannot occur.

cc: @alecmerdler

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@rhamilto
Copy link
Member Author

/test console-e2e

@spadgett
Copy link
Member

spadgett commented Feb 1, 2019

/retest

2 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Feb 1, 2019

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Feb 1, 2019

/retest

@rhamilto rhamilto changed the title Fix bug where .co-m-horizontal-nav__menu__secondary does not scroll i… [3.9] Fix bug where .co-m-horizontal-nav__menu__secondary does not scroll i… Feb 1, 2019
@rhamilto rhamilto changed the title [3.9] Fix bug where .co-m-horizontal-nav__menu__secondary does not scroll i… [enterprise-3.9] Fix bug where .co-m-horizontal-nav__menu__secondary does not scroll i… Feb 1, 2019
@rhamilto rhamilto changed the title [enterprise-3.9] Fix bug where .co-m-horizontal-nav__menu__secondary does not scroll i… Fix bug where .co-m-horizontal-nav__menu__secondary does not scroll i… Feb 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 6a8cd50 into openshift:master Feb 1, 2019
@rhamilto rhamilto deleted the console-1048 branch February 4, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants