Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2092140: Avoid using 'gp2' hardcoded storage class #11618

Merged
merged 1 commit into from Jun 16, 2022
Merged

[release-4.10] Bug 2092140: Avoid using 'gp2' hardcoded storage class #11618

merged 1 commit into from Jun 16, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #11603

/assign rottencandy

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 31, 2022
Merged
4 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@openshift-cherrypick-robot: Bugzilla bug 2084635 has been cloned as Bugzilla bug 2092140. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2092140: Avoid using 'gp2' hardcoded storage class

In response to this:

[release-4.10] Bug 2084635: Avoid using 'gp2' hardcoded storage class

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 2084635: Avoid using 'gp2' hardcoded storage class [release-4.10] Bug 2092140: Avoid using 'gp2' hardcoded storage class May 31, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2092140, which is invalid:

  • expected dependent Bugzilla bug 2084635 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.10] Bug 2092140: Avoid using 'gp2' hardcoded storage class

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/pipelines Related to pipelines-plugin labels May 31, 2022
rottencandy
rottencandy approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@rottencandy rottencandy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 4.10 cluster using clusterbot, works as expected.
0
/cc @karthikjeeyar @invincibleJai

@invincibleJai
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@invincibleJai: This pull request references Bugzilla bug 2092140, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2084635 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2084635 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot requested a review from sanketpathak June 13, 2022 09:23
@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, openshift-cherrypick-robot, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@sanketpathak
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 15, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 53d6dea and 8 for PR HEAD dd55c68 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 53d6dea and 7 for PR HEAD dd55c68 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 53d6dea and 6 for PR HEAD dd55c68 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD b0d66c2 and 5 for PR HEAD dd55c68 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD b0d66c2 and 4 for PR HEAD dd55c68 in total

@jerolimov
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 50ae0c3 and 3 for PR HEAD dd55c68 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 166145a into openshift:release-4.10 Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2092140 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2092140: Avoid using 'gp2' hardcoded storage class

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rottencandy
Copy link
Contributor

/cherrypick release-4.9

@openshift-cherrypick-robot
Copy link
Author

@rottencandy: new pull request created: #11716

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rottencandy rottencandy rottencandy approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@invincibleJai invincibleJai

@rottencandy rottencandy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality component/pipelines Related to pipelines-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @invincibleJai @sanketpathak @openshift-ci-robot @jerolimov @rottencandy