Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2092319: [Firefox] multi-line node status formatting issue #11638

Merged
merged 1 commit into from Jul 26, 2022
Merged

Bug 2092319: [Firefox] multi-line node status formatting issue #11638

merged 1 commit into from Jul 26, 2022

Conversation

tvu20
Copy link
Contributor

@tvu20 tvu20 commented Jun 3, 2022

Displays the 'Name' column text correctly when node is unschedulable in Firefox browser.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2092319

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@tvu20: This pull request references Bugzilla bug 2092319, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2092319: [Firefox] multi-line node status formatting issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/sdk Related to console-plugin-sdk label Jun 3, 2022
@spadgett
Copy link
Member

spadgett commented Jun 6, 2022

/cc @sg00dwin @rhamilto

@openshift-ci openshift-ci bot requested review from rhamilto and sg00dwin June 6, 2022 20:01
sg00dwin
sg00dwin reviewed Jun 6, 2022
View reviewed changes
frontend/packages/console-dynamic-plugin-sdk/src/app/components/status/PopoverStatus.scss Outdated
@@ -0,0 +1,7 @@
.popover-status {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.popover-status {
.co-popover-status {

We prefix with .co-

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further, an element should not exist without a block. This should really be .co-popover-status-button.

sg00dwin
sg00dwin approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 6, 2022
@sg00dwin
Copy link
Member

sg00dwin commented Jun 7, 2022

/retest

@sg00dwin
Copy link
Member

sg00dwin commented Jun 9, 2022

/retest-required

@sg00dwin
Copy link
Member

/test e2e-gcp-console

@tvu20
Copy link
Contributor Author

tvu20 commented Jun 22, 2022

/retest-required

@tvu20
Bug 2092319: [Firefox] multi-line node status formatting issue
bb61e27 
Displays the 'Name' column text correctly when node is unschedulable in Firefox browser.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2092319
@tvu20
Copy link
Contributor Author

tvu20 commented Jun 24, 2022

/retest

1 similar comment
@tvu20
Copy link
Contributor Author

tvu20 commented Jul 5, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 5, 2022

/retest-required

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 5, 2022

/retest

5 similar comments
@tvu20
Copy link
Contributor Author

tvu20 commented Jul 7, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 13, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 13, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 14, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 14, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 15, 2022

/retest

5 similar comments
@tvu20
Copy link
Contributor Author

tvu20 commented Jul 15, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 18, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 19, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 19, 2022

/retest

@tvu20
Copy link
Contributor Author

tvu20 commented Jul 20, 2022

/retest

@sg00dwin
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@tvu20
Copy link
Contributor Author

tvu20 commented Jul 21, 2022

/retest

jhadvig
jhadvig approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, sg00dwin, tvu20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@tvu20
Copy link
Contributor Author

tvu20 commented Jul 25, 2022

/retest

1 similar comment
@tvu20
Copy link
Contributor Author

tvu20 commented Jul 25, 2022

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 15589a4 and 8 for PR HEAD bb61e27 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@tvu20: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c083473 into openshift:master Jul 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@tvu20: All pull requests linked via external trackers have merged:

Bugzilla bug 2092319 has been moved to the MODIFIED state.

In response to this:

Bug 2092319: [Firefox] multi-line node status formatting issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@sg00dwin sg00dwin sg00dwin approved these changes

@yapei yapei Awaiting requested review from yapei

@christianvogt christianvogt Awaiting requested review from christianvogt

@spadgett spadgett Awaiting requested review from spadgett

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@jhadvig jhadvig

@sg00dwin sg00dwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/sdk Related to console-plugin-sdk lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tvu20 @spadgett @sg00dwin @openshift-ci-robot @rhamilto @jhadvig @openshift-merge-robot