Bug 1671605 - Hide Machines nav section from normal users #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/M
TheRealJon
reviewed
Feb 5, 2019
frontend/public/components/nav.jsx
Outdated
| const MachineNavSection_ = ({flags}) => { | ||
| // Only check RBAC for MachineConfig since Machines are a namespaced resource. | ||
| // There's no easy way to check the user's permission in all namespaces. | ||
| return flags[FLAGS.CLUSTER_API] && flags[FLAGS.MACHINE_CONFIG] && flags[FLAGS.CAN_LIST_MACHINE_CONFIG] |
There was a problem hiding this comment.
Should we adjust the 'required' prop for the NavSection component to take an array instead of a single flag?
spadgett
force-pushed
the
machine-config-permissions
branch
from
11b3bad
to
dff9211
Compare
openshift-ci-robot
added
size/S
spadgett
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@TheRealJon thanks, updated |
spadgett
force-pushed
the
machine-config-permissions
branch
from
dff9211
to
a72dd07
Compare
|
install failed /retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1671605
Fixes https://jira.coreos.com/browse/CONSOLE-1238
/assign @TheRealJon