Fix bug where nav doesn't collapse when resizing to mobile #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
spadgett
requested changes
Feb 5, 2019
rhamilto
force-pushed
the
console-1020
branch
from
7ef9caa
to
9cb0dda
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
rhamilto
force-pushed
the
console-1020
branch
from
9cb0dda
to
bea80e3
Compare
|
/retest |
rhamilto
force-pushed
the
console-1020
branch
from
bea80e3
to
d37af67
Compare
spadgett
reviewed
Feb 6, 2019
frontend/public/components/app.jsx
Outdated
| } | ||
|
|
||
| componentWillUnmount() { | ||
| super.componentWillUnmount(); |
There was a problem hiding this comment.
I don't think we need the call to super.componentWillUnmount() since this isn't extending SafetyFirst
rhamilto
force-pushed
the
console-1020
branch
from
d37af67
to
43fa257
Compare
spadgett
approved these changes
Feb 7, 2019
|
|
||
| @media screen and (min-width: $grid-float-breakpoint) { | ||
| --pf-c-page__sidebar--BoxShadow: none; | ||
| } | ||
|
|
||
| &.pf-m-expanded { | ||
| width: var(--pf-c-page__sidebar--md--Width) !important; // maintain desktop width so size doesn't animate before hiding when resizing to mobile |
rhamilto
force-pushed
the
console-1020
branch
from
43fa257
to
b9e1a0a
Compare
|
/lgtm |
|
Sorry. I'm a dolt and committed and force pushed in the wrong terminal tab, resulting in this change. There are no new changes. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
The local console couldn't find index.html on startup, hm.
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.coreos.com/browse/CONSOLE-1020
After:
