-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cluster Settings > Cluster Operators sort by status #1174
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
TheRealJon:cluster-operators-sort
Feb 8, 2019
Merged
Fix Cluster Settings > Cluster Operators sort by status #1174
openshift-merge-robot
merged 1 commit into
openshift:master
from
TheRealJon:cluster-operators-sort
Feb 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Feb 6, 2019
spadgett
requested changes
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for one small comment
TheRealJon
force-pushed
the
cluster-operators-sort
branch
from
February 7, 2019 13:26
ff7d6b5
to
43e25cc
Compare
openshift-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Feb 7, 2019
spadgett
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test frontend |
/retest |
6 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
Annotations flake /retest |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug which caused the sort functionality not to work for the status column on the Cluster Operators tab of the Cluster Settings page.
Fixes https://jira.coreos.com/browse/CONSOLE-1263