Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cluster Settings > Cluster Operators sort by status #1174

Merged

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Feb 6, 2019

Fix a bug which caused the sort functionality not to work for the status column on the Cluster Operators tab of the Cluster Settings page.

Fixes https://jira.coreos.com/browse/CONSOLE-1263

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for one small comment

frontend/public/components/factory/list.tsx Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/test frontend
/test backend

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

6 similar comments
@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

Annotations flake

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6b859f6 into openshift:master Feb 8, 2019
@TheRealJon TheRealJon deleted the cluster-operators-sort branch March 12, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants