New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2100669: Don't log usernames with the telemetry plugin #11759
Conversation
@jerolimov: This pull request references Bugzilla bug 2100669, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
/cc @serenamarie125 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, invincibleJai, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jerolimov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jerolimov: All pull requests linked via external trackers have merged: Bugzilla bug 2100669 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2100669
Analysis / Root cause:
All paths are logged, if the admin navigates to user management > users > a user the URL contains the username.
Solution Description:
For a specific path we now removes the username. It removes the username in all/most cases.
Screen shots / Gifs for design review:
Unit test coverage report:
Added a small test for the new utils
Test setup:
--telemetry=DEBUG=true
, for example:bin/bridge -listen "http://0.0.0.0:9000/" -user-settings-location configmap --telemetry=DEBUG=true
Browser conformance:
/kind bug
/cc @divyanshiGupta @invincibleJai